bpo-43795: Generate python3dll.c and doc data from manifest (PEP 652) #25315
Conversation
Each section is sorted to reduce diffs (review effort) when the file becomes generated. Sort is done with key=str.lower to preserve most of the original order (underscored items first).
|
I anticipate discussions taking a while, so I also opened #25312 to reduce diffs for reviewers. |
|
PyMarshal_*, PyMember_{Get,Set}One, PyThreadState_DeleteCurrent,
Py_GetArgcArgv are not declared with Py_LIMITED_API,
so they're not part of the limited API. They stay in the stable ABI, though.
PyInterpreterState_GetID part of limited API and stable ABI.
PyOS_ReadlineFunctionPointer is removed from the stable ABI records,
as functions expecting FILE* are not part of the ABI. Ssee bpo-43868.
|
Despite some buildbots timing out os failing |
encukou
merged commit f6ee4da
into
python:master
65 of 75 checks passed
65 of 75 checks passed
bedevere/news
News entry found in Misc/NEWS.d
This was referenced Apr 29, 2021
This was referenced Apr 29, 2021
kreathon
added a commit
to kreathon/cpython
that referenced
this pull request
May 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Here's an initial stab at PEP 652 – Maintaining the Stable ABI
There are two reviews I'm looking for:
Tools/scripts/stable_abi.py– @pablogsal, hope you're OK with that. I prefixed all the tool/platform-specific functions withgccorbinutilsDoc/data/stable_abi.dat(the limited API) andPC/python3dll.c(Windows stable ABI) and thecheck-limited-apifailure should show some juicy controversial items.(Docs, tests and more file generators/checks to come later.)
https://bugs.python.org/issue43795