-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-36461: timeit - Additional changes for autorange #12954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- have `timeit` and `repeat` methods (and functions) fall back on `autorange` if the number is set to 0 or None.
Was there consideration given to adding Since |
that was not discussed in issue36461 |
Actually, looking at things more carefully, I don't think it's necessary, since it looks like |
if i understand this correctly |
There is a proposal to rename it to "target_time", as Steven wrote in https://bugs.python.org/issue36461 |
ISTM that almost the entire point of having autorange() was to avoid the need for configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has merge conflicts now.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
timeit
andrepeat
methods (and functions) fall backon
autorange
if the number is set to 0 or None.https://bugs.python.org/issue36461