Skip to content

bpo-40212: Re-enable posix_fadvise and f_allocate on AIX #19403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented Apr 7, 2020

@isidentical isidentical added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 7, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @isidentical for commit 4881d1a 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 7, 2020
@taleinat
Copy link
Contributor

Would it be possible to check for the version of AIX to only enable this on recent enough versions where this bug is indeed fixed?

@kadler
Copy link
Contributor

kadler commented Nov 14, 2020

@taleinat That would require a new configure check. An easy way to do so would be to add a try_compile and see if posix_fadvise and posix_fallocate are defined as macros to posix_fadvise64 and posix_fallocate64. Something like:

#include <fcntl.h>

#if defined(_LARGE_FILES) && !defined(__64BIT__) && !defined(posix_fadvise)
#error posix_fadvise contains the wrong definition on this AIX
#endif

void foo() {}

@tiran
Copy link
Member

tiran commented Nov 17, 2020

Would it be possible to check for the version of AIX to only enable this on recent enough versions where this bug is indeed fixed?

I wouldn't bother. The issue has been fixed in 2014 and the bug was finally closed in 2016.

@isidentical There is a conflict. Please rebase your PR and re-generate argument clinic file.

@isidentical
Copy link
Member Author

I also would like to hear @aixtools 's opinions on this

@aixtools
Copy link
Contributor

reading. attending a (remote) conference today. will be back soon.

@aixtools
Copy link
Contributor

Quick feedback: need to look at which version it is fixed. Maybe the AIX versions where it is buggy are no longer being considered (e.g., AIX 5 and before).

@isidentical
Copy link
Member Author

Maybe the AIX versions where it is buggy are no longer being considered (e.g., AIX 5 and before).

We already removed support for them, so that is one of the points (AFAIK the lowest we support right now is 6.1).

@tiran
Copy link
Member

tiran commented Nov 17, 2020

According to https://www.ibm.com/support/pages/apar/IV56170 the bug was fixed in AIX7.1.

@kadler
Copy link
Contributor

kadler commented Nov 17, 2020

Looks like there's a related APAR for 6.1: https://www.ibm.com/support/pages/apar/IV47048

Edit: Looks like it was marked "fixed in next release", though, so 6.1 would seem permanently broken.

@aixtools
Copy link
Contributor

aixtools commented Nov 18, 2020 via email

@isidentical
Copy link
Member Author

I was not able to find it in AIX 6.1 (AIX 7.1 TL3 parallels AIX 6.1 TL9

  • AIX 6.1 TL10 was never released, so likely, it was never fixed, read
    released, in 6.1).

I am not too interested in dropping AIX 6.1 support right away

@furkanonder
Copy link
Contributor

@isidentical Could you resolve the conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants