bpo-32745: Fix a regression in the handling of ctypes' c_wchar_p type #8721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embedded nulls would cause a ValueError to be raised. Thanks go to Eryk Sun for their analysis.
ZackerySpytz
force-pushed
the
bpo-32745-ctypes-c_wchar_p-embedded-nulls
branch
from
73653ae to
5ecaf25
Compare
|
Any reason why this is sitting unreviewed? Encountered this issue today. |
|
I've also encountered this issue, would be great if the fix could progress.. |
|
@ambv: Please replace |
|
Thanks @ZackerySpytz for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Thanks @ZackerySpytz for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 2, 2021
…pythonGH-8721) Embedded nulls would cause a ValueError to be raised. Thanks go to Eryk Sun for their analysis. Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit 73766b0) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
|
GH-25811 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 2, 2021
…pythonGH-8721) Embedded nulls would cause a ValueError to be raised. Thanks go to Eryk Sun for their analysis. Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit 73766b0) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
|
GH-25812 is a backport of this pull request to the 3.9 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedded nulls would cause a ValueError to be raised. Thanks go to
Eryk Sun for their analysis.
https://bugs.python.org/issue32745