fix(footer): Remove Toolbar padding if in Tabs (bottom) or Keyboard opened #23193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ionic Latest
Merge latest master
latest ionic
latest ionic
latest ionic
# Conflicts: # core/src/components/footer/footer.tsx # core/src/components/tabs/test/basic/index.html # core/src/components/tabs/test/placements/index.html
Merged
13 tasks
|
Thanks for the PR! We greatly appreciate your work fixing this issue. Due to this PR's age, and for the sake of making tests and other adjustments easier, I've opened a fresh PR over at #25746 which leverages these changes. You'll be given co-author credit when it is merged. I'm going to close this one out in favor of the newer one, but let me know if you have any questions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17560
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently the Ion Footer Elements always adds
padding-bottom: var(--ion-safe-area-bottom, 0);to the last Ion Toolbar.Issue Number: #17560
What is the new behavior?
The Style is not applied if:
<ion-tabs>Element with an at the bottom placed<ion-tab-bar>Does this introduce a breaking change?