MNT Use mypy --allow-redefinition + config #18313
Merged
Conversation
can't hurt! |
@@ -17,7 +17,7 @@ jobs: | |||
inputs: | |||
versionSpec: '3.8' | |||
- bash: | | |||
pip install flake8 mypy==0.780 | |||
pip install flake8 mypy==0.782 |
NicolasHug
Aug 31, 2020
Member
can you remind me why we hardcode the version? Is it to avoid differences with the pre-commits?
rth
Aug 31, 2020
Author
Member
That and to avoid breaking CI if ever they make a backward incompatible release (not sure if they would, but I guess it's safer).
LGTM |
ac8760d
into
scikit-learn:master
22 checks passed
22 checks passed
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas)
Linux pylatest_pip_openblas_pandas succeeded
Details
scikit-learn.scikit-learn (Linux32 py36_ubuntu_atlas_32bit)
Linux32 py36_ubuntu_atlas_32bit succeeded
Details
scikit-learn.scikit-learn (Linux_Runs pylatest_conda_mkl)
Linux_Runs pylatest_conda_mkl succeeded
Details
scikit-learn.scikit-learn (Windows py36_pip_openblas_32bit)
Windows py36_pip_openblas_32bit succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_mkl_no_openmp)
macOS pylatest_conda_mkl_no_openmp succeeded
Details
jayzed82
added a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Several mypy related changes,
--allow-redefinition
option. For instance, without this flag,setup.cfg
to make usage a bit more user friendly.