Skip to content

/ scikit-learn

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT replace master with main #19237

Merged
merged 3 commits into from Jan 22, 2021
Merged

MNT replace master with main #19237

merged 3 commits into from Jan 22, 2021

Conversation

@adrinjalali
Copy link
Member

@adrinjalali adrinjalali commented Jan 22, 2021 •
edited

replacing instances of master with main when it comes to scikit-learn/scikit-learn repo

towards #17595
@adrinjalali
replace master with main
868c58d
@glemaitre
glemaitre reviewed Jan 22, 2021
View changes
doc/themes/scikit-learn/static/img/scikit-learn-logo.svg Show resolved Hide resolved
@glemaitre
Copy link
Contributor

@glemaitre glemaitre commented Jan 22, 2021

@jeremiedbb
Copy link
Member

@jeremiedbb jeremiedbb commented Jan 22, 2021

@adrinjalali the renaming closed ~40 PRs. Some of them were recent and approved.
I think it's due to that xxxxxx wants to merge 1 commit into scikit-learn:master from unknown repository.
I don't know what's going on. Does it mean the author deleted his fork after making the PR ?
@glemaitre
glemaitre reviewed Jan 22, 2021
View changes
doc/conf.py Show resolved Hide resolved
@adrinjalali
Copy link
Member Author

@adrinjalali adrinjalali commented Jan 22, 2021

Yes, people tend to delete their forks or local branches and then it's lost. I'm not sure what we'd do with those even if this change hadn't closed them
@adrinjalali
adrinjalali reviewed Jan 22, 2021
View changes
doc/themes/scikit-learn/layout.html Show resolved Hide resolved
@glemaitre
glemaitre reviewed Jan 22, 2021
View changes
doc/faq.rst Outdated Show resolved Hide resolved
@glemaitre
glemaitre reviewed Jan 22, 2021
View changes
doc/themes/scikit-learn/layout.html Show resolved Hide resolved
@glemaitre
glemaitre approved these changes Jan 22, 2021
View changes
Copy link
Contributor

@glemaitre glemaitre left a comment

LGTM
@adrinjalali @glemaitre
fix imbalanced-learn
dde32ab 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@glemaitre
Copy link
Contributor

@glemaitre glemaitre commented Jan 22, 2021

@adrinjalali the renaming closed ~40 PRs. Some of them were recent and approved.
I think it's due to that xxxxxx wants to merge 1 commit into scikit-learn:master from unknown repository.
I don't know what's going on. Does it mean the author deleted his fork after making the PR ?

unknown repository means that it has been deleted from the user account (I recall something similar with @reshamas).
What would be interesting is to track these PRs and to put them at stalled if they are something to be addressed.
@jeremiedbb
jeremiedbb approved these changes Jan 22, 2021
View changes
asv_benchmarks/asv.conf.json Outdated Show resolved Hide resolved
@adrinjalali
Copy link
Member Author

@adrinjalali adrinjalali commented Jan 22, 2021

@reshamas 's docs also need to be updated for the sprint.

@amueller may want to re-record his tutorial 🙈
@cmarmo
Copy link
Member

@cmarmo cmarmo commented Jan 22, 2021 •
edited

What would be interesting is to track these PRs and to put them at stalled if they are something to be addressed.

I'm quickly checking them: a vast majority was already labeled as stalled... or need decision... it seems that github decided...
@adrinjalali @jeremiedbb
asv default branch is master
9cdd691 
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
@jeremiedbb jeremiedbb mentioned this pull request Jan 22, 2021
Merged
@glemaitre
Copy link
Contributor

@glemaitre glemaitre commented Jan 22, 2021

OK so we will be merging once the CIs are green.
@cmarmo cmarmo mentioned this pull request Jan 22, 2021
Open
@adrinjalali adrinjalali merged commit 468c3f4 into scikit-learn:main Jan 22, 2021
27 checks passed
27 checks passed
@github-actions
triage
Details
@github-actions
Check build trigger
Details
@github-actions
Build wheel for cp${{ matrix.python }}-${{ matrix.platform_id }}
Details
@github-actions
Source distribution
Details
@github-actions
Upload to Anaconda
Details
@lgtm-com
LGTM analysis: C/C++ No new or fixed alerts
Details
@lgtm-com
LGTM analysis: JavaScript No new or fixed alerts
Details
@lgtm-com
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
@circleci-artifacts-redirector
ci/circleci: doc artifact Link to 0/doc/_changed.html
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
@codecov
codecov/patch Coverage not affected when comparing 8ea176a...9cdd691
Details
@codecov
codecov/project 97.97% (+0.00%) compared to 8ea176a
Details
@azure-pipelines
scikit-learn.scikit-learn Build #20210122.203 succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Get Git Commit) Get Git Commit succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Linting) Linting succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Linux py36_conda_openblas) Linux py36_conda_openblas succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Linux py36_ubuntu_atlas) Linux py36_ubuntu_atlas succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas) Linux pylatest_pip_openblas_pandas succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Linux32 py36_ubuntu_atlas_32bit) Linux32 py36_ubuntu_atlas_32bit succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Linux_Runs pylatest_conda_mkl) Linux_Runs pylatest_conda_mkl succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Windows py36_pip_openblas_32bit) Windows py36_pip_openblas_32bit succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (macOS pylatest_conda_forge_mkl) macOS pylatest_conda_forge_mkl succeeded
Details
@azure-pipelines
scikit-learn.scikit-learn (macOS pylatest_conda_mkl_no_openmp) macOS pylatest_conda_mkl_no_openmp succeeded
Details
@adrinjalali adrinjalali deleted the adrinjalali:master-to-main branch Jan 22, 2021
glemaitre added a commit that referenced this pull request Jan 22, 2021
@adrinjalali @glemaitre @jeremiedbb
MNT replace master with main (#19237)
891605d 
* replace master with main

* fix imbalanced-learn

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

* asv default branch is `master`

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
10 of 12 tasks
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@adrinjalali @glemaitre @jeremiedbb
MNT replace master with main (scikit-learn#19237)
6af16bb 
* replace master with main

* fix imbalanced-learn

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

* asv default branch is `master`

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
glemaitre added a commit that referenced this pull request Apr 28, 2021
@adrinjalali @glemaitre @jeremiedbb
MNT replace master with main (#19237)
54571bf 
* replace master with main

* fix imbalanced-learn

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

* asv default branch is `master`

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre

@jeremiedbb jeremiedbb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@adrinjalali @glemaitre @jeremiedbb @cmarmo