bpo-44012: IPv6Address.exploded with scope_id #25824
Open
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 30 days with no activity. |
Support for scoped IPv6 addresses was implemented in bpo-34788
but missed implementing the .exploded method:
>>> import ipaddress
>>> ipaddress.IPv6Address('fe80::1%eth0').exploded
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3.9/ipaddress.py", line 394, in exploded
return self._explode_shorthand_ip_string()
File "/usr/lib/python3.9/ipaddress.py", line 1824, in _explode_shorthand_ip_string
ip_int = self._ip_int_from_string(ip_str)
File "/usr/lib/python3.9/ipaddress.py", line 1705, in _ip_int_from_string
raise AddressValueError("%s in %r" % (exc, ip_str)) from None
ipaddress.AddressValueError: Only hex digits permitted in '1%eth0' in 'fe80::1%eth0'
After this commit:
>>> import ipaddress
>>> ipaddress.IPv6Address('fe80::1%eth0').exploded
'fe80:0000:0000:0000:0000:0000:0000:0001%eth0'
ohwgiles
force-pushed
the
ipv6address-exploded-with-scope_id
branch
from
3852867
to
3902135
Compare
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for scoped IPv6 addresses was implemented in bpo-34788 but missed implementing the .exploded method:
After this commit:
https://bugs.python.org/issue44012