Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41222: new tests for demonstrating polling problem on subprocess with universal_newlines=True #25859

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ydirson
Copy link

@ydirson ydirson commented May 3, 2021

This is a testcase only, not a fix. Why commit ab85ff3 even fixed part of the problem is not clear to me.

See #85394

ab85ff3 fixed for 3.2.2 problems with
subprocess and universal_newlines=True, notably the use of select() on its
output.  The problem can be seen its parent commit
e96ec68, and seems to come from a big
py3k refactoring.  This particular issue is exercised by new
test_stdout_pipe_readline_select().

However, it still does not work with poll(), as shown by new
test_stdout_pipe_readline_poll(), issue recorded in
https://bugs.python.org/issue41222

Both tests pass on 2.7 (once adapted to use raw_input() rather than getting
py3 input() semantics).

Note: a related problem was solved 877766d
for 3.1.4 for universal_newlines=False.  The testcase provided in that
commit also does not check that select() will work after not all data
was read.

Signed-off-by: Yann Dirson <ydirson@free.fr>
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented May 3, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@ydirson

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label May 3, 2021
@github-actions
Copy link

github-actions bot commented Jun 18, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 18, 2021
@ydirson
Copy link
Author

ydirson commented Dec 21, 2021

Maybe @pitrou would have an opinion on this ?

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants