Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36581: Fix dir() on MagicMock with tuple specs #12753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dsem
Copy link

@dsem dsem commented Apr 9, 2019

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Apr 9, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@dsem dsem force-pushed the fix-issue-36581 branch 2 times, most recently from c292b21 to e6878dd Compare Apr 9, 2019
@kushaldas
Copy link
Member

kushaldas commented May 6, 2019

@dsem this PR needs update.

@matrixise
Copy link
Member

matrixise commented May 7, 2019

@brettcannon I can't change the CLA label and the CLA has been signed (checked on bpo).

@matrixise
Copy link
Member

matrixise commented May 7, 2019

@dsem There is a problem with your commit, you have used another user for your commit. You have committed with fp-dsem and not dsem. Could you fix this point, because without that, the CLA is not found and we can't merge it.

Also,

  • could you fix the issue with test_unittest?
  • update your PR with master?

Thank you

@dsem dsem force-pushed the fix-issue-36581 branch 2 times, most recently from d6ad8f9 to 95aefc1 Compare May 7, 2019
@dsem
Copy link
Author

dsem commented May 7, 2019

Nice find about me using the wrong username. I believe I've addressed all the issues now.

Thanks!

@csabella csabella added the type-feature A feature request or enhancement label Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants