bpo-39902: support equality comparisons in dis.Bytecode #18849
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidentical
commented
Mar 8, 2020
| @@ -536,6 +536,16 @@ def dis(self): | |||
| lasti=offset) | |||
| return output.getvalue() | |||
|
|
|||
| def __eq__(self, other): | |||
There was a problem hiding this comment.
I didn't add a check about underlying code object because I think we should compare the bytecode not the source but I'm OK to change it if needed?
>>> dis.Bytecode("print(1)") == dis.Bytecode(compile("print(1)", "<stdin>", "eval"))
True
>>> dis.Bytecode("print(1)")._original_object == dis.Bytecode(compile("print(1)", "<stdin>", "eval"))._original_object
False
akuchling
reviewed
Mar 8, 2020
|
@serhiy-storchaka any suggestion / thought about the subject? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue39902