bpo-40124: Explain an assert when waiting on a asyncio stream drain #19240
Conversation
If a task is waiting on a stream to drain and another task tries to this assertion will fail. It wasn't clear at first glance why the assertion failed, but I hope with this message it will be.
There was a problem hiding this comment.
Thanks for your PR! Can you also--
- Add your name to the ACKS file
- Add a NEWS entry with "Patch by " at the end: https://devguide.python.org/committing/#what-s-new-and-news-entries
| @@ -191,7 +191,9 @@ async def _drain_helper(self): | |||
| if not self._paused: | |||
| return | |||
| waiter = self._drain_waiter | |||
| assert waiter is None or waiter.cancelled() | |||
| assert waiter is None or waiter.cancelled(), ( | |||
| 'Another task is waiting for this stream to drain' | |||
There was a problem hiding this comment.
I think this would be a little clearer if it said, "Another task is already waiting for this stream to drain"
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
If a task is waiting on a stream to drain and another task tries to
this assertion will fail. It wasn't clear at first glance why the
assertion failed, but I hope with this message it will be.
https://bugs.python.org/issue40124