bpo-40307: Preserve manager Client in multiprocessing managers #19609
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Hi @amol-, thanks for looking into the issue!
The fix and the tests look correct. The changes are not trivial though so you will need the sign the CLA and to add a blurb (https://devguide.python.org/committing/#what-s-new-and-news-entries) to describe the changes, you can do this using https://blurb-it.herokuapp.com/.
|
@remilapeyre I should have signed the CLA before submitting the PR, but I guess it might take a while before it figures. Let me know if it worked or if there is any action pending on my side. PS: I tried to add a NEWS entry using blurp-it, let me know if the style suites what's expected. |
Misc/NEWS.d/next/Library/2020-04-20-10-40-54.bpo-40307.b4YXXY.rst
Outdated
Show resolved
Hide resolved
|
The bot should find it later then. Thanks for adding the blob, it should be in the present tense and there is a small typo. |
Co-Authored-By: Rémi Lapeyre <remi.lapeyre@henki.fr>
|
Hi @amol-, can you please fix the conflix with |
|
@remilapeyre Just wanted to follow-up to make sure there isn't anything else pending for this PR and it's only waiting for review. Let me know if there is any way I can help. |
https://bugs.python.org/issue40307