bpo-39783: Optimize contruction of Path and PurePath objects #20288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remilapeyre
changed the title
|
Could this be implemented in |
Yes, thanks! |
|
LGTM! |
akulakov
reviewed
Aug 14, 2021
| @@ -686,7 +686,9 @@ def _parse_args(cls, args): | |||
| return cls._flavour.parse_parts(parts) | |||
|
|
|||
| @classmethod | |||
| def _from_parts(cls, args, init=True): | |||
| def _from_parts(cls, args, kwargs=None, *, init=True): | |||
There was a problem hiding this comment.
It looks like kwargs is not needed as it's not used anywhere?
There was a problem hiding this comment.
It has been removed on main, you have a merge conflict now.
|
Closing - see rationale in issue. Thanks all the same for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the
_closedattribute has been removed we can move ahead with this.https://bugs.python.org/issue39783