Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41004: IPv4Interface, and IPv6Interface hash collisions #20956

Open
wants to merge 2 commits into
base: master
from

Conversation

@sreev
Copy link

@sreev sreev commented Jun 17, 2020

@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Jun 17, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@sreev

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@sreev
Copy link
Author

@sreev sreev commented Jun 18, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@sreev

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Just signed the CLA. Thanks.
/Sree

@sreev sreev changed the title [https://bugs.python.org/issue41004] Hash collisions [https://bugs.python.org/issue41004] 41004 Hash collisions Jun 18, 2020
@amiremohamadi
Copy link
Contributor

@amiremohamadi amiremohamadi commented Jun 18, 2020

Hi @sreev!
I think this change will need a NEWS entry.
you can add NEWS using https://blurb-it.herokuapp.com/

Copy link
Member

@ericvsmith ericvsmith left a comment

It would be good to add some tests for this. Maybe just something that asserts that two IPv4Interface objects have different hashes. Same for IPv6Interface.

And as noted elsewhere, it needs a NEWS entry.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 18, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ericvsmith ericvsmith changed the title [https://bugs.python.org/issue41004] 41004 Hash collisions [https://bugs.python.org/issue41004] bpo-41004 IPv4Interface, and IPv6Interface hash collisions Jun 18, 2020
@tiran tiran changed the title [https://bugs.python.org/issue41004] bpo-41004 IPv4Interface, and IPv6Interface hash collisions bpo-41004: IPv4Interface, and IPv6Interface hash collisions Jun 18, 2020
@ned-deily
Copy link
Member

@ned-deily ned-deily commented Jun 30, 2020

It looks like this PR has been superseded by #21033?

@kirotawa
Copy link

@kirotawa kirotawa commented Jul 3, 2020

Hi,

Is this issue completely solved already? I'm seeing "resolved" in https://bugs.python.org/issue41004 , but here it's still open. So just would like to be sure.

@j-wags j-wags mentioned this pull request Sep 21, 2020
0 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.