Skip to content

[WIP/RFC] pathlib: revisit error handling #23025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[WIP/RFC] pathlib: revisit error handling #23025

wants to merge 2 commits into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 29, 2020 •
edited by bedevere-bot
Loading

Refs:

@blueyed
pathlib: _Selector: factor out _skip_entry
2883096 
Refs:

- bpo-24120 (python@6c2d33a258bb)
  uses to broad try/catch for PermissionError, which led to bpo-38894 in
  the first place
- bpo-38894 (python#18815)
  fixed handling only for `_WildcardSelector`
  TODO: tests for others?
@blueyed
use "yield from"
ff099bc
@gvanrossum
Copy link
Member

Can you explain in more words what you are proposing here? Maybe even discuss it in the issue (even if closed) first?

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@blueyed
Copy link
Contributor Author

blueyed commented Dec 16, 2020

This refactors/cleans up the error handling, which is (inconsistently) used in several places (IIRC).
It was only a byproduct from looking at the code, and certainly would need some proper review.
Having coverage information for the PR diff would be useful to have.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Dec 17, 2020
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 30, 2022
@barneygale
Copy link
Contributor

The handling of OSError exceptions in pathlib.Path.glob() was revised in 94f30c7 (3.12). It should be much more consistent + obvious now.

@blueyed would you mind if I close this PR?

@barneygale
Copy link
Contributor

Closing per my previous comment. Thanks all the same!

@barneygale barneygale closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review topic-pathlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@blueyed @gvanrossum @barneygale @brettcannon @the-knights-who-say-ni @ezio-melotti @bedevere-bot