Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42037: Corrected request dependencies in CookieJar functions #23112

Merged
merged 1 commit into from Aug 1, 2022
Merged

bpo-42037: Corrected request dependencies in CookieJar functions #23112

merged 1 commit into from Aug 1, 2022

Conversation

markus-sus
Copy link
Contributor

@markus-sus markus-sus commented Nov 2, 2020 •
edited by bedevere-bot

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Nov 2, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@markus-sus

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 2, 2020
@markus-sus
Copy link
Contributor Author

markus-sus commented Nov 2, 2020

I signed the agreement now and setup my bug tracker account properly.
Hopefully this will be resolved automatically then in a day or two.

Fidget-Spinner
Fidget-Spinner approved these changes Nov 4, 2020
View changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

LGTM. The entries changed from :meth: to :attr: do seem to corroborate with the docs for Request Objects.

@github-actions
Copy link

github-actions bot commented Dec 16, 2020

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@markus-sus
Copy link
Contributor Author

markus-sus commented Dec 16, 2020

Is there anything I should do for this? I assume not

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Dec 17, 2020
@github-actions
Copy link

github-actions bot commented Jan 16, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021
@markus-sus
Copy link
Contributor Author

markus-sus commented Feb 17, 2021

I see that the news item is required. Is it really needed for this relatively small change?

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Feb 17, 2021

I see that the news item is required. Is it really needed for this relatively small change?

Usually not. However only triagers and core devs can apply the skip news label (Zackery and I cant).

Since Eric is on the bpo, gentle ping to @merwok . Sorry to disturb.

@markus-sus markus-sus mannequin mentioned this pull request Apr 10, 2022
Open
@AA-Turner AA-Turner added skip news and removed CLA signed stale Stale PR or inactive for long period of time. labels Jun 8, 2022
@AA-Turner AA-Turner closed this Jun 8, 2022
@AA-Turner AA-Turner reopened this Jun 8, 2022
@AA-Turner
Copy link
Member

AA-Turner commented Jun 8, 2022

Trigger CLA.

A

@github-actions
Copy link

github-actions bot commented Jul 31, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 31, 2022
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 1, 2022
@Fidget-Spinner Fidget-Spinner merged commit d29e279 into python:main Aug 1, 2022
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 1, 2022

Thanks @markus-sus for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Aug 1, 2022

GH-95514 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 1, 2022
@markus-sus @miss-islington
bpo-42037: Corrected request dependencies in CookieJar functions (pyt…
4a3cdea 
…honGH-23112)

(cherry picked from commit d29e279)

Co-authored-by: markus-sus <73822103+markus-sus@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 1, 2022
@markus-sus @miss-islington
bpo-42037: Corrected request dependencies in CookieJar functions (pyt…
cdc48eb 
…honGH-23112)

(cherry picked from commit d29e279)

Co-authored-by: markus-sus <73822103+markus-sus@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 1, 2022

GH-95515 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Aug 1, 2022
@miss-islington @markus-sus
bpo-42037: Corrected request dependencies in CookieJar functions (GH-…
a4cda28 
…23112)

(cherry picked from commit d29e279)

Co-authored-by: markus-sus <73822103+markus-sus@users.noreply.github.com>
ambv pushed a commit that referenced this pull request Aug 5, 2022
@miss-islington @markus-sus
bpo-42037: Corrected request dependencies in CookieJar functions (GH-…
57446f9 
…23112) (GH-95515)

(cherry picked from commit d29e279)

Co-authored-by: markus-sus <73822103+markus-sus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZackerySpytz ZackerySpytz

@Fidget-Spinner Fidget-Spinner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@markus-sus @the-knights-who-say-ni @Fidget-Spinner @AA-Turner @miss-islington @bedevere-bot @ZackerySpytz