Skip to content

[WIP] bpo-42260: Rewrite getpath.c in Python #23169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[WIP] bpo-42260: Rewrite getpath.c in Python #23169

wants to merge 2 commits into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 5, 2020 •
edited by bedevere-bot
Loading

  • Add _getpath Python module and _cgetpath C module
  • Py_SetPath() no longer computes the path configuration.

https://bugs.python.org/issue42260

@vstinner
Copy link
Member Author

vstinner commented Nov 5, 2020

The PR is still a draft.

Modules/getpath.c is reimplemented in pure Python as Lib/_getpath.py. The module is frozen by "make regen-importlib" and run by by pyinit_main():

PyRun_SimpleString("import _getpath; _getpath.main()");

I kept Modules/getpath.c to ease development, but it will be fully removed in the final patch.

There are likely bugs in my conversion from getpath.c (C) to _getpath.py (Python).

The new Python module gets a companion _cgetpath: a C extension to expose functions needed by _getpath (Python).

Code size: 1623 lines for getpath.c (C) => 654 lines for _getpath.py (Python), and way simpler string manipulation: 2.5x smaller code.

Right now, 4 tests are still failing (test_embed, test_sys, test_gdb and a 4th that I forgot!).

@vstinner
Copy link
Member Author

vstinner commented Nov 5, 2020

cc @ncoghlan @zooba

See also https://www.python.org/dev/peps/pep-0432/

@vstinner
[WIP] bpo-42260: Rewrite getpath.c in Python
6225151 
* Add _getpath Python module and _cgetpath C module
* Py_SetPath() no longer computes the path configuration.
* _PyErr_SetFromPyStatus() now raises SystemExit if the status is an
  exit code.
@vstinner
Avoid hardcoded constants
49b150d 
Also move PathConfig class
@vstinner
Copy link
Member Author

Remaining issue: test_init_read_set() fails. The error on Windows is different than the error on Linux/macOS.

Windows:

-  'base_executable': 'D:\\a\\cpython\\cpython\\PCbuild\\amd64\\_testembed.exe',
+  'base_executable': 'my_executable',

Linux/macOS:


   'module_search_paths': ['/opt/python-dev/lib/python310.zip',
-                          'Lib',
?                           ^ ^

+                          'test_path_insert1',
?                           ^^^^^^^^^^ ^^^^^^

+                          '/Users/runner/work/cpython/cpython/Lib',
-                          'build/lib.macosx-10.15-x86_64-3.10-pydebug'],
?                                                                      -

+                          '/Users/runner/work/cpython/cpython/build/lib.macosx-10.15-x86_64-3.10-pydebug',
?                           +++++++++++++++++++++++++++++++++++

+                          'test_path_append'],

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 26, 2020
@vstinner vstinner closed this Sep 21, 2021
@vstinner vstinner deleted the getpath_py branch September 21, 2021 21:56
@vstinner vstinner mentioned this pull request Oct 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 will be requested when the pull request is marked ready for review FFY00 is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner

@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity will be requested when the pull request is marked ready for review ZeroIntensity is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner

Assignees
No one assigned
Labels
awaiting core review stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot