Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42158: Add MIME types for n-triples, n-quads, n3 and trig #23230

Merged
merged 3 commits into from Nov 20, 2021
Merged

bpo-42158: Add MIME types for n-triples, n-quads, n3 and trig #23230

merged 3 commits into from Nov 20, 2021

Conversation

DylanVanAssche
Copy link
Contributor

@DylanVanAssche DylanVanAssche commented Nov 10, 2020 •
edited by miss-islington

Adds MIME types to Lib/mimetypes.py for:

https://bugs.python.org/issue42158

@DylanVanAssche DylanVanAssche requested a review from a team as a code owner Nov 10, 2020
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Nov 10, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@DylanVanAssche

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

github-actions bot commented Dec 18, 2020

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 18, 2020
@pheyvaer
Copy link

pheyvaer commented Jan 28, 2021

This would be very useful my work too!

merwok
merwok approved these changes Jan 28, 2021
View changes
Copy link
Member

@merwok merwok left a comment

I can confirm these 4 entries exist in /etc/mime.types in current Debian testing.

@DylanVanAssche
Copy link
Contributor Author

DylanVanAssche commented Jan 28, 2021 •
edited

I can confirm these 4 entries exist in /etc/mime.types in current Debian testing.

Not in Ubuntu 20.04 LTS unfortunately, maybe a later Ubuntu version.

@DylanVanAssche @merwok
Update Misc/NEWS.d/next/Library/2020-11-10-17-46-12.bpo-42158.OhxAiH.rst
2e4ec54 
Co-authored-by: Éric Araujo <merwok@netwok.org>
@merwok
Copy link
Member

merwok commented Jan 28, 2021

Sorry for the confusion — I wasn’t saying that to mean you should not change Python’s mimetypes, but to mean that the mappings are correct 🙂

@merwok merwok added 🤖 automerge PR will be merged once it's been approved and all CI passed needs backport to 3.9 and removed stale Stale PR or inactive for long period of time. 🤖 automerge PR will be merged once it's been approved and all CI passed labels Jan 28, 2021
merwok
merwok approved these changes Jan 28, 2021
View changes
@DylanVanAssche
Copy link
Contributor Author

DylanVanAssche commented Jan 28, 2021

Sorry for the confusion — I wasn’t saying that to mean you should not change Python’s mimetypes, but to mean that the mappings are correct slightly_smiling_face

No problem 😃

@merwok merwok closed this Jul 31, 2021
@merwok merwok reopened this Jul 31, 2021
@merwok merwok self-assigned this Jul 31, 2021
@ambv
Copy link
Contributor

ambv commented Nov 19, 2021

This looks ready for inclusion. However, since 3.10 is out and 3.9 is pretty late in the game, I'd like to learn if there is an exception to "no new features in bugfix releases" when it comes to adding MIME types.

@merwok
Copy link
Member

merwok commented Nov 19, 2021 •
edited

I think there is an informal exception for registries that have definitions external to Python; in previous tickets it was deemed safe and beneficial to backport new entries. I think I remember than @terryjreedy or maybe @bitdancer were involved.

Tickets with backports:

Backport avoided to avoid compat issue: https://bugs.python.org/issue22589

→ Found one of the discussions of the policy here: https://bugs.python.org/issue13952#msg152752

@terryjreedy
Copy link
Member

terryjreedy commented Nov 20, 2021 •
edited

R. David Murray was much more involved in such decisions. As the last link indicates, the debate tended to be framed as whether the item missing is a bug, rather than an exceptional new feature.

Eric, thank you for the research!

@ambv
Copy link
Contributor

ambv commented Nov 20, 2021

Given R. David's conservative approach (which I share) demonstrated in the last link by Eric, I'll merge this to 3.11 alone. Unless a backwards incompatibility is demonstrated, we won't be backporting to 3.10 and 3.9.

@ambv ambv merged commit ef53058 into python:main Nov 20, 2021
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Nov 20, 2021

Thanks @DylanVanAssche for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2021
@DylanVanAssche @miss-islington
bpo-42158: Add MIME types for n-triples, n-quads, n3 and trig (python…
baf2a70 
…GH-23230)

Co-authored-by: Éric Araujo <merwok@netwok.org>
(cherry picked from commit ef53058)

Co-authored-by: Dylan Van Assche <me@dylanvanassche.be>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2021
@DylanVanAssche @miss-islington
bpo-42158: Add MIME types for n-triples, n-quads, n3 and trig (python…
6aa5b27 
…GH-23230)

Co-authored-by: Éric Araujo <merwok@netwok.org>
(cherry picked from commit ef53058)

Co-authored-by: Dylan Van Assche <me@dylanvanassche.be>
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@DylanVanAssche @merwok @remykarem
bpo-42158: Add MIME types for n-triples, n-quads, n3 and trig (python…
02971be 
…GH-23230)

Co-authored-by: Éric Araujo <merwok@netwok.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok

@python/email-team email-team

Assignees

@merwok merwok

Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@DylanVanAssche @the-knights-who-say-ni @pheyvaer @merwok @ambv @terryjreedy @miss-islington @bedevere-bot