bpo-41626: Remove the shebang of internal Tools to avoid confusion. #23581
Conversation
shihai1991
requested review from
lysnikolaou,
markshannon,
pablogsal,
tiran and
as
code owners
shihai1991
changed the title
shihai1991
changed the title
|
@merwok @ned-deily Hi, Eric, Ned. Can you take a look when you have free time? Thanks. |
|
Does «inner Tools» mean «internal Tools» (used for CPython dev but not for regular people)? |
Yes. I am not a native English speaker, so I don't there have the obvious difference between |
shihai1991
changed the title
Objects/typeslots.py
Outdated
| @@ -1,5 +1,4 @@ | |||
| #!/usr/bin/python | |||
| # Usage: typeslots.py < Include/typeslots.h typeslots.inc | |||
| # Usage: ./python typeslots.py < Include/typeslots.h typeslots.inc | |||
There was a problem hiding this comment.
This looks wrong; either you're in the directory with ./python or in Objects.
Same for _sha3/cleanup.py. Did you try these commands?
There was a problem hiding this comment.
This looks wrong; either you're in the directory with ./python or in Objects.
Oh, you are right. I just point out developer should use ./python in old usage. Using entire command would be better. I will update it.
Same for _sha3/cleanup.py. Did you try these commands?
the command in _sha3/cleanup.py is a entire command.
There was a problem hiding this comment.
There have an another question. Typeslots.py should be moved to the dir of Tools? It's weird leave it alone in Objects. Maybe we should open an new bpo to discuss it.
| @@ -1,5 +1,3 @@ | |||
| #!/usr/bin/env python3 | |||
| # | |||
There was a problem hiding this comment.
I don't think Clinic needs a locally built Python.
There was a problem hiding this comment.
Yes. It doesn't need a local builtin python. There have docs to introduce how to run this clinic.py. So I think remove it would be better(Avoid update the python version again and again).
| @@ -1,4 +1,3 @@ | |||
| #! /usr/bin/env python | |||
There was a problem hiding this comment.
I don't think makeopcodetargets needs a locally built Python. Does it?
There was a problem hiding this comment.
You are right. It will be called in makefile: https://github.com/python/cpython/blob/master/Makefile.pre.in#L946.
So I think the shebang haven't worked in here.
|
This PR is stale because it has been open for 30 days with no activity. |
The following files' shebang now be removed:
https://bugs.python.org/issue41626