Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: use python -m pip rather than plain pip in examples #24003

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@scop
Copy link
Contributor

@scop scop commented Dec 29, 2020

@vsajip
vsajip approved these changes Dec 30, 2020

.. code-block:: bash
(tutorial-env) $ pip show requests
(tutorial-env) $ python -m pip show requests

This comment has been minimized.

@rhettinger

rhettinger Dec 30, 2020
Contributor

The examples already in a virtual environment should not be changed because the whole point of the environment is to make sure the correct python and pip are being targeted.

This comment has been minimized.

@scop

scop Jan 2, 2021
Author Contributor

I can revert those if that's what it takes to get this merged (please confirm), but would like to point out first that

  • they will then be the only places referring to the pip executable rather than python -m pip which might be a surprise to some readers, it gets more rare and there's no explanation for it, and
  • the point of using python -m pip instead of pip is just as valid in virtual envs as it is outside of them
@github-actions
Copy link

@github-actions github-actions bot commented Feb 2, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Feb 2, 2021
@scop
Copy link
Contributor Author

@scop scop commented Feb 2, 2021

Pending @rhettinger comments above, not stale as far as I'm concerned.

@github-actions github-actions bot removed the stale label Feb 3, 2021
@github-actions
Copy link

@github-actions github-actions bot commented Mar 5, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Mar 5, 2021
@scop
Copy link
Contributor Author

@scop scop commented Mar 5, 2021

Still not stale I think, see above.

@github-actions github-actions bot removed the stale label Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants