bpo-35026: Mention required permissions in the winreg.DeleteKey*() docs #24547
Conversation
Use the exact warning text from the docs for winreg.SetValue() and winreg.SetValueEx().
| @@ -131,6 +131,9 @@ This module offers the following functions: | |||
|
|
|||
| *This method can not delete keys with subkeys.* | |||
|
|
|||
| The key identified by the *key* parameter must have been opened with | |||
| :const:`KEY_SET_VALUE` access. | |||
|
|
|||
There was a problem hiding this comment.
Per the message I left on the tracker, this should state that key can have any access. It's only used to resolve the relative path in sub_key.
| @@ -165,6 +168,9 @@ This module offers the following functions: | |||
|
|
|||
| *This method can not delete keys with subkeys.* | |||
|
|
|||
| The key identified by the *key* parameter must have been opened with | |||
| :const:`KEY_SET_VALUE` access. | |||
|
|
|||
There was a problem hiding this comment.
Per the message I left on the tracker, this should state that key can have any access. It's only used to resolve the relative path in sub_key.
Also, using KEY_WOW64_64KEY instead of 0 as the default value of access is wrong (i.e. it's the wrong default behavior for 32-bit Python). And the usage of KEY_WOW64_64KEY and KEY_WOW64_32KEY -- the only relevant access modes for sub_key -- should probably be discussed in terms how the relative path in sub_key is traversed starting from the path of the key that's referenced by the key handle.
|
This PR is stale because it has been open for 30 days with no activity. |
|
Closing as @eryksun's comments haven't been addressed and it's been more than a year. Feel free to reopen this PR or open a new one if you'd like to continue. |
Use the exact warning text from the docs for winreg.SetValue()
and winreg.SetValueEx().
https://bugs.python.org/issue35026