Skip to content

Remove the get_phrase_cfws_only_raises test #24871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elenril
Copy link

@elenril elenril commented Mar 15, 2021

No description provided.

@elenril elenril requested a review from a team as a code owner March 15, 2021 10:28
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@elenril

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Apr 16, 2021
@elenril
Copy link
Author

elenril commented Apr 23, 2021

Ping.

Still waiting for review.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Apr 24, 2021
This test's name does not start with test_, which prevents it from
running. Apparently it was accidentally added this way.

None of the callers of get_phrase() assume it can raise exceptions, so
simply dropping the test seems best. The fact that the phrase is invalid
still gets recorded in defects.
@elenril elenril force-pushed the email_remove_disabled_test branch from 53f5acf to 799ebe1 Compare September 8, 2023 11:27
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants