Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42725: Render annotations effectless on symbol table with PEP 563 #25583

Merged
merged 2 commits into from May 3, 2021
Merged

bpo-42725: Render annotations effectless on symbol table with PEP 563 #25583

merged 2 commits into from May 3, 2021

Conversation

@isidentical
Copy link
Member

@isidentical isidentical commented Apr 25, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue42725
@isidentical isidentical force-pushed the isidentical:bpo-42725 branch from 1835825 to 9ba052d Apr 25, 2021
@isidentical isidentical changed the title bpo-42725: Don't process annotations on the symbol table bpo-42725: Render annotations effectless on symbol table Apr 25, 2021
@isidentical isidentical changed the title bpo-42725: Render annotations effectless on symbol table bpo-42725: Render annotations effectless on symbol table with PEP 563 Apr 25, 2021
@isidentical isidentical requested a review from pablogsal Apr 25, 2021
@pablogsal
pablogsal reviewed May 1, 2021
View changes
Lib/test/test_future.py Show resolved Hide resolved
@pablogsal
pablogsal reviewed May 1, 2021
View changes
Misc/NEWS.d/next/Core and Builtins/2021-04-25-05-40-51.bpo-42725.WGloYm.rst Outdated Show resolved Hide resolved
@pablogsal
pablogsal reviewed May 1, 2021
View changes
Python/symtable.c Outdated Show resolved Hide resolved
@pablogsal
pablogsal reviewed May 1, 2021
View changes
Python/symtable.c Outdated Show resolved Hide resolved
@pablogsal
pablogsal reviewed May 1, 2021
View changes
Python/symtable.c Outdated Show resolved Hide resolved
@pablogsal
pablogsal reviewed May 1, 2021
View changes
Modules/symtablemodule.c Show resolved Hide resolved
@NAPADAI
NAPADAI approved these changes May 1, 2021
View changes
isidentical added 2 commits Dec 25, 2020
@isidentical
bpo-42725: Don't process annotations on the symbol table
5c7d796
@isidentical
add the missing tests, remove IS_PSEUDO_BLOCK macro
Loading status checks…
7493334
@isidentical isidentical force-pushed the isidentical:bpo-42725 branch from 9ba052d to 7493334 May 1, 2021
@isidentical
Copy link
Member Author

@isidentical isidentical commented May 1, 2021 

 $ ./python -m test -R3:3 test_symtable test_future
0:00:00 load avg: 2.61 Run tests sequentially
0:00:00 load avg: 2.61 [1/2] test_symtable
beginning 6 repetitions
123456
......
0:00:00 load avg: 2.61 [2/2] test_future
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

All 2 tests OK.

Total duration: 565 ms
Tests result: SUCCESS
@isidentical isidentical requested a review from pablogsal May 1, 2021
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 3, 2021

🤖 New build scheduled with the buildbot fleet by @isidentical for commit 7493334 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.
@isidentical isidentical merged commit ad106c6 into python:master May 3, 2021
20 of 24 checks passed
20 of 24 checks passed
@github-actions
Docs
Details
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL ${{ matrix.openssl_ver }}
Details
@bedevere-bot
buildbot/AMD64 Debian root PR Build done.
Details
@bedevere-bot
buildbot/PPC64 Fedora PR Build done.
Details
@bedevere-bot
buildbot/x86-64 macOS PR Build done.
Details
@bedevere-bot
buildbot/x86 Gentoo Installed with X PR Build started.
Details
Azure Pipelines PR #20210501.27 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 42725 found
Details
@bedevere-bot
bedevere/news News entry found in Misc/NEWS.d
@bedevere-bot
buildbot/AMD64 Debian PGO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Ubuntu Shared PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Windows10 PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Windows10 Pro PR Build done.
Details
@bedevere-bot
buildbot/aarch64 Fedora Stable PR Build done.
Details
@bedevere-bot
buildbot/aarch64 RHEL8 PR Build done.
Details
@bedevere-bot
buildbot/s390x Debian PR Build done.
Details
@bedevere-bot
buildbot/s390x SLES PR Build done.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NAPADAI NAPADAI

@pablogsal pablogsal

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@isidentical @bedevere-bot @pablogsal @NAPADAI @the-knights-who-say-ni