Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-44063: set the missing end locations on the compiler #25956

Merged
merged 1 commit into from May 7, 2021

Conversation

@isidentical
Copy link
Member

@isidentical isidentical commented May 6, 2021

@isidentical
Copy link
Member Author

@isidentical isidentical commented May 6, 2021

Is 3.9 needed?

@pablogsal
Copy link
Member

@pablogsal pablogsal commented May 6, 2021

Is 3.9 needed?

Actually no, good point

@isidentical isidentical merged commit b2ec37a into python:main May 7, 2021
11 checks passed
11 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
Azure Pipelines PR #20210506.40 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 44063 found
Details
@bedevere-bot
bedevere/news "skip news" label found
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 7, 2021

Thanks @isidentical for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 7, 2021

GH-25972 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 7, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.x has failed when building commit b2ec37a.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/506/builds/181) and take a look at the build logs.
  4. Check if the failure is related to this commit (b2ec37a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/506/builds/181

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

409 tests OK.

10 slowest tests:

  • test_concurrent_futures: 4 min 11 sec
  • test_unparse: 3 min 16 sec
  • test_gdb: 3 min 15 sec
  • test_multiprocessing_spawn: 3 min 2 sec
  • test_peg_generator: 3 min 1 sec
  • test_capi: 2 min 54 sec
  • test_tokenize: 2 min 41 sec
  • test_asyncio: 2 min 29 sec
  • test_lib2to3: 1 min 57 sec
  • test_multiprocessing_forkserver: 1 min 23 sec

1 test altered the execution environment:
test_ftplib

17 tests skipped:
test_devpoll test_idle test_ioctl test_kqueue test_msilib
test_ossaudiodev test_startfile test_tcl test_tix test_tk
test_ttk_guionly test_ttk_textonly test_turtle test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 29 min 3 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/threading.py", line 990, in _bootstrap_inner
    self.run()
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_ftplib.py", line 292, in run
    asyncore.loop(timeout=0.1, count=1)
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/asyncore.py", line 207, in loop
    poll_fun(timeout, map)
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/asyncore.py", line 150, in poll
    read(obj)
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/asyncore.py", line 87, in read
    obj.handle_error()
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_ftplib.py", line 415, in handle_error
    raise Exception
Exception


Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/asyncore.py", line 83, in read
    obj.handle_read_event()
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_ftplib.py", line 382, in handle_read_event
    super(SSLConnection, self).handle_read_event()
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/asyncore.py", line 420, in handle_read_event
    self.handle_read()
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/asynchat.py", line 171, in handle_read
    self.found_terminator()
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_ftplib.py", line 129, in found_terminator
    method(arg)
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_ftplib.py", line 154, in cmd_pasv
    conn, addr = sock.accept()
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/socket.py", line 293, in accept
    fd, addr = self._accept()
TimeoutError: timed out
@isidentical
Copy link
Member Author

@isidentical isidentical commented May 7, 2021

Just for the reference, it is a timeout error on ftplib nothing relevant;

Warning -- Uncaught thread exception: Exception
Exception in thread Thread-84:
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/asyncore.py", line 83, in read
    obj.handle_read_event()
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_ftplib.py", line 382, in handle_read_event
    super(SSLConnection, self).handle_read_event()
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/asyncore.py", line 420, in handle_read_event
    self.handle_read()
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/asynchat.py", line 171, in handle_read
    self.found_terminator()
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_ftplib.py", line 129, in found_terminator
    method(arg)
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_ftplib.py", line 154, in cmd_pasv
    conn, addr = sock.accept()
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/socket.py", line 293, in accept
    fd, addr = self._accept()
TimeoutError: timed out
isidentical added a commit that referenced this pull request May 7, 2021
…25972)

(cherry picked from commit b2ec37a)

Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants