bpo-31704 Check HTTP response in uppercase #3870
Conversation
Recently faced an issue with a proxy responding in lowercase http, which caused this:
```python
ProtocolError('Connection aborted.', BadStatusLine('http/1.1 200 connection established\r\n',))
```
Changing the string to uppercase before checking if it starts with HTTP fixes this issue and allows to use this proxy.
I know that the proxy is at fault here, but seeing as other applications (web browsers, office suite, text editors, etc.) still work behind this proxy, I think it might be a reasonable fix to have...
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
perroboc
changed the title
|
Please re-check the CLA signature :) |
|
Thanks @AlvaroMunoz. Since https://bugs.python.org/issue31704 was closed as not-a-bug, I'm closing the PR as well. |
Recently faced an issue with a proxy responding in lowercase http, which caused this:
Changing the string to uppercase before checking if it starts with HTTP fixes this issue and allows to use this proxy.
I know that the proxy is at fault here, but seeing as other applications (web browsers, office suite, text editors, etc.) still work behind this proxy, I think it might be a reasonable fix to have...
https://bugs.python.org/issue31704