Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34272: Reorganize C API tests. #8551

Merged
merged 3 commits into from Nov 10, 2022
Merged

bpo-34272: Reorganize C API tests. #8551

merged 3 commits into from Nov 10, 2022
+9 −0

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 29, 2018 •
edited

Move most some C API tests into Lib/test/test_capi/.

https://bugs.python.org/issue34272

@serhiy-storchaka serhiy-storchaka added the tests Tests in the Lib/test dir label Jul 29, 2018
auvipy
auvipy approved these changes Aug 16, 2018
View changes
@arhadthedev
Copy link
Contributor

arhadthedev commented Mar 27, 2022

Is the idea to group C API tests still feasible? It would be great to immediately see from a file structure that test_getargs2.py and test_structmembers.py are not about Python libraries or their module backends.

iritkatriel
iritkatriel requested changes Nov 9, 2022
View changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Merge conflicts need to be resolved.

@bedevere-bot
Copy link

bedevere-bot commented Nov 9, 2022

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Nov 10, 2022

Thank you for a reminder. I completely forget about this simple PR.

@serhiy-storchaka serhiy-storchaka merged commit f883b7f into python:main Nov 10, 2022
15 checks passed
@serhiy-storchaka serhiy-storchaka deleted the test_capi branch Nov 10, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Nov 10, 2022

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Nov 10, 2022

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2022
@serhiy-storchaka @miss-islington
bpo-34272: Reorganize C API tests. (pythonGH-8551)
b91896a 
Move some C API tests into Lib/test/test_capi/.
(cherry picked from commit f883b7f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 10, 2022

GH-99314 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2022
@serhiy-storchaka @miss-islington
bpo-34272: Reorganize C API tests. (pythonGH-8551)
d027568 
Move some C API tests into Lib/test/test_capi/.
(cherry picked from commit f883b7f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 10, 2022

GH-99315 is a backport of this pull request to the 3.11 branch.

@encukou encukou mentioned this pull request Nov 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel

@auvipy auvipy

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@serhiy-storchaka @arhadthedev @bedevere-bot @miss-islington @iritkatriel @auvipy @the-knights-who-say-ni @ezio-melotti