Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken name in build.yml #25759

Merged
merged 1 commit into from May 1, 2021
Merged

Conversation

@brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Apr 30, 2021

This check is skipped for most PRs. When skipped, the job currently displays as Ubuntu SSL tests with OpenSSL ${{ matrix.openssl_ver }} (since the matrix is not actually populated, interpolating the name fails).

This changes the display name to just Ubuntu SSL tests with OpenSSL. For PRs that don't skip the check, GitHub automatically adds the value of matrix.openssl_ver to the job name (as you can see below).

@brandtbucher
Copy link
Member Author

@brandtbucher brandtbucher commented Apr 30, 2021

The failures are unrelated (due to bpo-43989).

@brandtbucher
Copy link
Member Author

@brandtbucher brandtbucher commented May 1, 2021

Closing and reopening to trigger a new CI build.

@brandtbucher brandtbucher reopened this May 1, 2021
@brandtbucher brandtbucher merged commit 29282b2 into python:master May 1, 2021
18 of 20 checks passed
18 of 20 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL (1.1.1k) Ubuntu SSL tests with OpenSSL (1.1.1k)
Details
@github-actions
Ubuntu SSL tests with OpenSSL (1.1.1k)
Details
@github-actions
Ubuntu SSL tests with OpenSSL (3.0.0-alpha15) Ubuntu SSL tests with OpenSSL (3.0.0-alpha15)
Details
@github-actions
Ubuntu SSL tests with OpenSSL (3.0.0-alpha15)
Details
Azure Pipelines PR #20210501.72 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue report skipped
@bedevere-bot
bedevere/news "skip news" label found
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 1, 2021

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 1, 2021

GH-25796 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request May 1, 2021
(cherry picked from commit 29282b2825545e2823bde94290a80f7c0fd7068e)

Co-authored-by: Brandt Bucher <brandt@python.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 1, 2021

GH-25797 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request May 1, 2021
(cherry picked from commit 29282b2)

Co-authored-by: Brandt Bucher <brandt@python.org>
brandtbucher pushed a commit that referenced this pull request May 2, 2021
(cherry picked from commit 29282b2)
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 2, 2021

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request May 2, 2021
(cherry picked from commit 29282b2)

Co-authored-by: Brandt Bucher <brandt@python.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 2, 2021

GH-25802 is a backport of this pull request to the 3.9 branch.

brandtbucher pushed a commit that referenced this pull request May 2, 2021
(cherry picked from commit 29282b2)
kreathon added a commit to kreathon/cpython that referenced this pull request May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants