Update lib types to mark Annex B as deprecated #43710
Conversation
You probably have to update baselines. If we do this, the first thing you'll see every time you request completions on a string is a bunch of crossed-out properties. @sandersn any idea how easy it would be to give them a lower sort order based on JSDoc tags? Ideally, we never would've shown these properties anyway, but we traditionally had to have them there because ES6. |
|
The TypeScript team hasn't accepted the linked issue #43709. If you can get it accepted, this PR will have a better chance of being reviewed. |
A quick grep of the baselines for /// <reference path='fourslash.ts' />
//// var s = "foo"./*1*/
verify.baselineCompletions() Which should make it obvious what order |
I think before this goes in, we need to add the sorting logic first. I'd like to discuss that at an upcoming editor sync with @mjbvz and others first. |
#43796 tracks that. |
CC @bterlson |
@sandersn [
{
"marker": {
"fileName": "/tests/cases/fourslash/completionsStringMethods.ts",
"position": 6,
"name": ""
},
"completionList": {
"isGlobalCompletion": true,
"isMemberCompletion": false,
"isNewIdentifierLocation": false,
"entries": [
{
"name": "globalThis",
"kind": "module",
"kindModifiers": "",
"sortText": "5"
},
{
"name": "eval",
"kind": "function",
"kindModifiers": "declare",
"sortText": "5"
},
// ...,
]
}
}
} I also found the following broken test. TypeScript/tests/cases/fourslash/completionsJSDocTags.ts Lines 60 to 62 in a14b227 |
I'm a fan of this, and I think the sorting would make it shine 👍🏻 |
Sorting PR: #43880 |
|
I found that |
This pull request can be reviewed. Thank you for your time. |
Looks good to me |
d699bcd
into
microsoft:main
Fixes #43709
Fixes #32191