Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a redundant assignment in Tools/unittestgui/unittestgui.py #21438

Merged
merged 2 commits into from May 16, 2021
Merged

Remove a redundant assignment in Tools/unittestgui/unittestgui.py #21438

merged 2 commits into from May 16, 2021
+0 −1

Conversation

@shidenko97
Copy link
Contributor

@shidenko97 shidenko97 commented Jul 10, 2020 •
edited by miss-islington

I've just removed duplicated defining an attribute __rollbackImporter in class BaseGUITestRunner, module unittestgui. It's not important, but Python code should be clear.

Automerge-Triggered-By: GH:iritkatriel
@shidenko97
Removed duplicate of defining __rollbackImporter in BaseGUITestRunner
Loading status checks…
b32bc61
@shidenko97 shidenko97 changed the title Removed duplicate of defining __rollbackImporter in BaseGUITestRunner Removed duplicate of defining __rollbackImporter in BaseGUITestRunner [skip issue] Jul 10, 2020
@shidenko97 shidenko97 changed the title Removed duplicate of defining __rollbackImporter in BaseGUITestRunner [skip issue] Removed duplicate of defining __rollbackImporter in BaseGUITestRunner [skip issue, skip news] Jul 10, 2020
@eamanu
eamanu approved these changes Jul 11, 2020
View changes
Copy link
Contributor

@eamanu eamanu left a comment

Hi! Good catch @shidenko97 LGTM.

IMO is very simple change, and I'm curious why this line is there.
@iritkatriel iritkatriel changed the title Removed duplicate of defining __rollbackImporter in BaseGUITestRunner [skip issue, skip news] Remove a redundant assignment in Tools/unittestgui/unittestgui.py May 16, 2021
@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented May 16, 2021

closing and reopening to get a current test run.
@iritkatriel iritkatriel reopened this May 16, 2021
@iritkatriel
iritkatriel approved these changes May 16, 2021
View changes
@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented May 16, 2021

This probably needs to be rebased.
@shidenko97
Merge branch 'main' into fix_unittestgui_duplicate
Loading status checks…
0b7cce8
@shidenko97
Copy link
Contributor Author

@shidenko97 shidenko97 commented May 16, 2021

This probably needs to be rebased.

@iritkatriel Main merged to current branch
@iritkatriel iritkatriel merged commit a42d98e into python:main May 16, 2021
10 of 11 checks passed
10 of 11 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86) Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
Azure Pipelines PR #20210516.25 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue report skipped
@bedevere-bot
bedevere/news "skip news" label found
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 16, 2021

Thanks @shidenko97 for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request May 16, 2021
@shidenko97 @miss-islington
Remove a redundant assignment in Tools/unittestgui/unittestgui.py (py…
26fc4f4 
…thonGH-21438)

(cherry picked from commit a42d98e)

Co-authored-by: Serhii Hidenko <shidenko97@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 16, 2021

GH-26168 is a backport of this pull request to the 3.10 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request May 16, 2021
@shidenko97 @miss-islington
Remove a redundant assignment in Tools/unittestgui/unittestgui.py (py…
f615800 
…thonGH-21438)

(cherry picked from commit a42d98e)

Co-authored-by: Serhii Hidenko <shidenko97@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 16, 2021

GH-26169 is a backport of this pull request to the 3.9 branch.
iritkatriel pushed a commit that referenced this pull request May 16, 2021
@miss-islington @shidenko97
Remove a redundant assignment in Tools/unittestgui/unittestgui.py (GH…
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
d43e1cb 
…-21438) (#26169)

(cherry picked from commit a42d98e)

Co-authored-by: Serhii Hidenko <shidenko97@gmail.com>
iritkatriel added a commit to iritkatriel/cpython that referenced this pull request May 16, 2021
@shidenko97 @iritkatriel
[3.10] Remove a redundant assignment in Tools/unittestgui/unittestgui…
26a54a4 
….py (pythonGH-21438)

(cherry picked from commit a42d98e)

Co-authored-by: Serhii Hidenko <shidenko97@gmail.com>
@iritkatriel iritkatriel mentioned this pull request May 16, 2021
Merged
iritkatriel added a commit that referenced this pull request May 16, 2021
@iritkatriel @shidenko97
[3.10] Remove a redundant assignment in Tools/unittestgui/unittestgui…
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
9b59b6f 
….py (GH-21438) (GH-26171)

(cherry picked from commit a42d98e)

Co-authored-by: Serhii Hidenko <shidenko97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel

@eamanu eamanu

Assignees
No one assigned
Labels
🤖 automerge CLA signed skip issue skip news
Projects
None yet
Milestone
No milestone
6 participants
@shidenko97 @iritkatriel @miss-islington @bedevere-bot @eamanu @the-knights-who-say-ni