Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-16866 Fix make libainstall. #25980

Merged
merged 1 commit into from May 8, 2021
Merged

bpo-16866 Fix make libainstall. #25980

merged 1 commit into from May 8, 2021
+1 −1

Conversation

@orsenthil
Copy link
Member

@orsenthil orsenthil commented May 8, 2021 •
edited 

make libainstall

target is broken.

./configure --prefix=/home/senthil/foobar
make libainstall

failed with 

/usr/bin/install: cannot create regular file '/home/senthil/foobar/bin/python3.11-config': No such file or directory
make: *** [Makefile:1715: libainstall] Error 1

Looks like the BINDIR dependency was added here - 49fd7fa#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767cR833 but we didn't add the directory creation dependency then.

A simple fix of add BINDIR as dependency seems OK to me. At least it wont break the libainstall standalone target.

With the fix, make libainstall works fine.

Creating directory /home/senthil/foobar2/lib
Creating directory /home/senthil/foobar2/lib/python3.11/config-3.11-x86_64-linux-gnu
Creating directory /home/senthil/foobar2/lib/pkgconfig
Creating directory /home/senthil/foobar2/bin
/usr/bin/install -c -m 644 Modules/config.c /home/senthil/foobar2/lib/python3.11/config-3.11-x86_64-linux-gnu/config.c
/usr/bin/install -c -m 644 ./Modules/config.c.in /home/senthil/foobar2/lib/python3.11/config-3.11-x86_64-linux-gnu/config.c.in
/usr/bin/install -c -m 644 Makefile /home/senthil/foobar2/lib/python3.11/config-3.11-x86_64-linux-gnu/Makefile
/usr/bin/install -c -m 644 ./Modules/Setup /home/senthil/foobar2/lib/python3.11/config-3.11-x86_64-linux-gnu/Setup
/usr/bin/install -c -m 644 Modules/Setup.local /home/senthil/foobar2/lib/python3.11/config-3.11-x86_64-linux-gnu/Setup.local
/usr/bin/install -c -m 644 Misc/python.pc /home/senthil/foobar2/lib/pkgconfig/python-3.11.pc
/usr/bin/install -c -m 644 Misc/python-embed.pc /home/senthil/foobar2/lib/pkgconfig/python-3.11-embed.pc
/usr/bin/install -c ./Modules/makesetup /home/senthil/foobar2/lib/python3.11/config-3.11-x86_64-linux-gnu/makesetup
/usr/bin/install -c ./install-sh /home/senthil/foobar2/lib/python3.11/config-3.11-x86_64-linux-gnu/install-sh
/usr/bin/install -c python-config.py /home/senthil/foobar2/lib/python3.11/config-3.11-x86_64-linux-gnu/python-config.py
/usr/bin/install -c python-config /home/senthil/foobar2/bin/python3.11-config

https://bugs.python.org/issue16866
@orsenthil
Fix libainstall.
Verified
This commit was signed with the committer’s verified signature.
orsenthil Senthil Kumaran
GPG key ID: 5EA272FAACCC125F Learn about vigilant mode.
Loading status checks…
f8d3812
@orsenthil orsenthil changed the title Fix libainstall. bpo-16866 Fix libainstall. May 8, 2021
@orsenthil orsenthil changed the title bpo-16866 Fix libainstall. bpo-16866 Fix make libainstall. May 8, 2021
@orsenthil orsenthil merged commit 80d250d into python:main May 8, 2021
11 checks passed
11 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
Azure Pipelines PR #20210508.7 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 16866 found
Details
@bedevere-bot
bedevere/news "skip news" label found
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 8, 2021

Thanks @orsenthil for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 8, 2021

Sorry @orsenthil, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 80d250d68cf3bb511fd862169c681b28028499c2 3.10
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 8, 2021

GH-25981 is a backport of this pull request to the 3.9 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request May 8, 2021
@orsenthil @miss-islington
Fix make libainstall. (pythonGH-25980)
3506f65 
Initial patch by Benno Leslie.
(cherry picked from commit 80d250d)

Co-authored-by: Senthil Kumaran <senthil@uthcode.com>
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 8, 2021

Thanks @orsenthil for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 8, 2021

GH-25982 is a backport of this pull request to the 3.10 branch.
miss-islington added a commit that referenced this pull request May 8, 2021
@miss-islington @orsenthil
Fix make libainstall. (GH-25980)
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
a25c46b 
Initial patch by Benno Leslie.
(cherry picked from commit 80d250d)

Co-authored-by: Senthil Kumaran <senthil@uthcode.com>
miss-islington added a commit that referenced this pull request May 8, 2021
@miss-islington @orsenthil
Fix make libainstall. (GH-25980)
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
a2c72d5 
Initial patch by Benno Leslie.
(cherry picked from commit 80d250d)

Co-authored-by: Senthil Kumaran <senthil@uthcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@orsenthil orsenthil

Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
4 participants
@orsenthil @miss-islington @bedevere-bot @the-knights-who-say-ni