Skip to content

typo-ish: improved comment that indicates state of Barrier #23755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

typo-ish: improved comment that indicates state of Barrier #23755

wants to merge 2 commits into from

Conversation

cpriyank
Copy link
Contributor

removed extra comma in comment that indicates state of a Barrier as it was confusing and breaking the flow while reading. Also added missing space after # that began the comment

@cpriyank
improved comment that indicates state of Barrier
5f5fa54 
removed extra comma in comment that indicates state of a `Barrier` as it was confusing and breaking the flow while reading
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@cpriyank

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@cpriyank cpriyank changed the title typo-ish: improved comment that indicates state of Barrier skip-issue: typo-ish: improved comment that indicates state of Barrier Dec 13, 2020
@cpriyank cpriyank changed the title skip-issue: typo-ish: improved comment that indicates state of Barrier skip issue: typo-ish: improved comment that indicates state of Barrier Dec 13, 2020
@cpriyank cpriyank changed the title skip issue: typo-ish: improved comment that indicates state of Barrier typo-ish: improved comment that indicates state of Barrier Dec 19, 2020
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 19, 2021
serverwentdown
serverwentdown approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@serverwentdown serverwentdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, erroneous extra comma in code comment.

eamanu
eamanu suggested changes May 11, 2021
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about a new commit for only for this change.

We can take in advantage some other bugs to fix this.

Also @cpriyank don't forget sign the CLA.

ambv
ambv reviewed Sep 29, 2021
View reviewed changes
@ambv ambv mentioned this pull request Sep 29, 2021
Merged
@ambv
Copy link
Contributor

ambv commented Sep 29, 2021

Closing in favor of GH-28623.

@ambv ambv closed this Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv ambv left review comments

@eamanu eamanu eamanu requested changes

@serverwentdown serverwentdown serverwentdown approved these changes

Assignees
No one assigned
Labels
awaiting core review skip issue skip news stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cpriyank @the-knights-who-say-ni @ambv @serverwentdown @eamanu @bedevere-bot