Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-15907: Move doctest test-data files into a subdirectory of Lib/test #25914

Closed
wants to merge 2 commits into from

Conversation

00Kai0
Copy link

@00Kai0 00Kai0 commented May 5, 2021

This is my first contribution for cpython :)

https://bugs.python.org/issue15907

Co-authored-by: @jaywink

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented May 5, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@00Kai0

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

github-actions bot commented Jun 13, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 13, 2021
>>> suite = doctest.DocFileSuite('test_doctest.txt',
... 'test_doctest2.txt',
... 'test_doctest4.txt')
>>> suite = doctest.DocFileSuite('doctest_DocFileSuite_test.txt',)
Copy link
Member

@cjerdonek cjerdonek Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this was changed?

Copy link
Author

@00Kai0 00Kai0 Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be a simple loader test. Multi file test has been done several times below.
If you think it's unreasonable, I can roll back~~

@00Kai0
Copy link
Author

00Kai0 commented Jul 23, 2021

close this pr

@00Kai0 00Kai0 closed this Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants