-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-43109: Use /usr/bin/ar on macOS for LTO builds #25999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Thanks for the PR, @xrisk, and the heads up, @matrixise. I will review and test this PR soon. |
I have made the requested changes; please review again I am not sure if I should also be committing the changed Secondly, in my testing I never hit this code path because the script incorrectly detects that I am using gcc, when I am not. I have filed an issue on the bpo about this https://bugs.python.org/issue44093 Lastly, is there some way to detect if the built binary actually uses LTO? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your modifications, now, we have to wait for a review of @ned-deily
PR #26341 was merged instead. |
https://bugs.python.org/issue43109