Skip to content

bpo-43109: Use /usr/bin/ar on macOS for LTO builds #25999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

xrisk
Copy link
Contributor

@xrisk xrisk commented May 9, 2021

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ned-deily
Copy link
Member

Thanks for the PR, @xrisk, and the heads up, @matrixise. I will review and test this PR soon.

@xrisk
Copy link
Contributor Author

xrisk commented May 10, 2021

I have made the requested changes; please review again

I am not sure if I should also be committing the changed configure file. It is quite a large diff for me; maybe because I am using autoconf 2.71 and not 2.69.

Secondly, in my testing I never hit this code path because the script incorrectly detects that I am using gcc, when I am not. I have filed an issue on the bpo about this https://bugs.python.org/issue44093

Lastly, is there some way to detect if the built binary actually uses LTO?

Copy link
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your modifications, now, we have to wait for a review of @ned-deily

@vstinner
Copy link
Member

cc @serge-sans-paille

@vstinner
Copy link
Member

PR #26341 was merged instead.

@vstinner vstinner closed this May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants