bpo-40222: Prevent access outside buffer #26012

sweeneyde · 2021-05-10T06:39:15Z

https://bugs.python.org/issue40222

markshannon · 2021-05-10T09:10:08Z

LGTM

bedevere-bot · 2021-05-10T10:24:43Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 3.x has failed when building commit 45862f9.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/509/builds/164) and take a look at the build logs.
Check if the failure is related to this commit (45862f9) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/509/builds/164

Failed tests:

test_asyncio

Summary of the results of the build (if available):

==

Click to see traceback logs

remote: Enumerating objects: 4, done.        
remote: Counting objects:  25% (1/4)        
remote: Counting objects:  50% (2/4)        
remote: Counting objects:  75% (3/4)        
remote: Counting objects: 100% (4/4)        
remote: Counting objects: 100% (4/4), done.        
remote: Compressing objects:  33% (1/3)        
remote: Compressing objects:  66% (2/3)        
remote: Compressing objects: 100% (3/3)        
remote: Compressing objects: 100% (3/3), done.        
remote: Total 4 (delta 1), reused 1 (delta 1), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '45862f9f5ef5d3c9da37f35e4fe4b18618530cfa'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 45862f9f5e Prevent access outside buffer (GH-26012)
Switched to and reset branch 'main'

./configure: line 10527: PKG_PROG_PKG_CONFIG: command not found

test_kqueue skipped -- test works only on BSD
test_winsound skipped -- No module named 'winsound'
test_winconsoleio skipped -- test only relevant on win32
test_winreg skipped -- No module named 'winreg'
test_ioctl skipped -- Unable to open /dev/tty
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... ok
test_kqueue (__main__.SelectEINTRTest) ... skipped 'need select.kqueue'
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 7.134s

OK (skipped=2)
test_ttk_guionly skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_badargs (__main__.GeneralTest) ... ok
test_bound_methods (__main__.GeneralTest) ... ok
test_clear (__main__.GeneralTest) ... ok
test_exit (__main__.GeneralTest) ... ok
test_order (__main__.GeneralTest) ... ok
test_raise (__main__.GeneralTest) ... ok
test_raise_unnormalized (__main__.GeneralTest) ... ok
test_stress (__main__.GeneralTest) ... ok
test_unregister (__main__.GeneralTest) ... ok

----------------------------------------------------------------------
Ran 9 tests in 0.001s

OK
test_devpoll skipped -- test works only on Solaris OS family
test_tk skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_ossaudiodev skipped -- [Errno 2] No such file or directory: '/dev/dsp'
test_startfile skipped -- object <module 'os' from '/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/os.py'> has no attribute 'startfile'
test_msilib skipped -- No module named '_msi'
test_nis skipped -- No module named 'nis'
test_tix skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
Timeout (0:15:00)!
Thread 0x000003ffab4f8b30 (most recent call first):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/selectors.py", line 469 in select
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/asyncio/base_events.py", line 1845 in _run_once
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/asyncio/base_events.py", line 595 in run_forever
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/asyncio/base_events.py", line 628 in run_until_complete
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/test_asyncio/test_subprocess.py", line 177 in test_kill
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/case.py", line 549 in _callTestMethod
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/case.py", line 592 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/case.py", line 652 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/runner.py", line 176 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/support/__init__.py", line 959 in _run_suite
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/support/__init__.py", line 1082 in run_unittest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/runtest.py", line 210 in _test_module
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/runtest.py", line 246 in _runtest_inner2
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/runtest.py", line 282 in _runtest_inner
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/runtest.py", line 141 in _runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/runtest.py", line 194 in runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/runtest_mp.py", line 81 in run_tests_worker
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/main.py", line 661 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/main.py", line 641 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/main.py", line 719 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/regrtest.py", line 43 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/regrtest.py", line 47 in <module>
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/runpy.py", line 86 in _run_code
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/runpy.py", line 196 in _run_module_as_main
Timeout (0:15:00)!
Thread 0x000003ff81e78b30 (most recent call first):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/selectors.py", line 469 in select
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/asyncio/base_events.py", line 1845 in _run_once
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/asyncio/base_events.py", line 595 in run_forever
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/asyncio/base_events.py", line 628 in run_until_complete
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/test_asyncio/test_subprocess.py", line 190 in test_terminate
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/case.py", line 549 in _callTestMethod
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/case.py", line 592 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/case.py", line 652 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/unittest/runner.py", line 176 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/support/__init__.py", line 959 in _run_suite
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/support/__init__.py", line 1082 in run_unittest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/runtest.py", line 210 in _test_module
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/runtest.py", line 246 in _runtest_inner2
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/runtest.py", line 282 in _runtest_inner
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/runtest.py", line 154 in _runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/runtest.py", line 194 in runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/main.py", line 321 in rerun_failed_tests
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/main.py", line 698 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/main.py", line 641 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/libregrtest/main.py", line 719 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/__main__.py", line 2 in <module>
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/runpy.py", line 86 in _run_code
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/runpy.py", line 196 in _run_module_as_main
make: *** [Makefile:1249: buildbottest] Error 1

Cannot open file '/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/test-results.xml' for upload

Prevent access outside buffer

eec7961

sweeneyde requested a review from markshannon as a code owner May 10, 2021

bedevere-bot added the awaiting review label May 10, 2021

the-knights-who-say-ni added the CLA signed label May 10, 2021

markshannon added the skip news label May 10, 2021

markshannon merged commit 45862f9 into python:main May 10, 2021
11 checks passed

bedevere-bot removed the awaiting review label May 10, 2021

python / cpython Public

bpo-40222: Prevent access outside buffer #26012

bpo-40222: Prevent access outside buffer #26012

sweeneyde commented May 10, 2021 •

edited by bedevere-bot

markshannon commented May 10, 2021

bedevere-bot commented May 10, 2021

python / cpython Public

bpo-40222: Prevent access outside buffer #26012

bpo-40222: Prevent access outside buffer #26012

Conversation

sweeneyde commented May 10, 2021 • edited by bedevere-bot

markshannon commented May 10, 2021

bedevere-bot commented May 10, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

sweeneyde commented May 10, 2021 •

edited by bedevere-bot