[Static Runtime] Support clamp.Tensor #58191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This pull request was exported from Phabricator. Differential Revision: D28371949 |
Summary: Pull Request resolved: pytorch#58191 There are two clamp overloads: clamp.Scalar and clamp.Tensor. SR needs to support both or has checks in place to avoid runtime errors. Supporting both is not too hard so here we are. Reviewed By: edvgha Differential Revision: D28371949 fbshipit-source-id: 430c6ba29655e8d331aee3ed3d2b6ed7ec988662
|
This pull request was exported from Phabricator. Differential Revision: D28371949 |
|
This pull request has been merged in 993a35a. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this issue
May 19, 2021
Summary: Pull Request resolved: pytorch#58191 There are two clamp overloads: clamp.Scalar and clamp.Tensor. SR needs to support both or has checks in place to avoid runtime errors. Supporting both is not too hard so here we are. Reviewed By: edvgha Differential Revision: D28371949 fbshipit-source-id: 0ec6b8a0b8c6277e50d8e51e4e7a45aa62211e22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Summary: There are two clamp overloads: clamp.Scalar and clamp.Tensor. SR needs to support both or has checks in place to avoid runtime errors. Supporting both is not too hard so here we are.
Differential Revision: D28371949
The text was updated successfully, but these errors were encountered: