Fix systemd comment syntax #10066
Merged
Fix systemd comment syntax #10066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comments for systemd service files are only allowed in the beginning of a new line https://www.freedesktop.org/software/systemd/man/systemd.syntax.html otherwise you get error messages like ``` /usr/lib/systemd/system/netdata.service:48: Failed to parse capability in bounding/ambient set, ignoring: # ```
|
|
|
@HolgerHees thx for the contribution 👍 There is CLA, sign it! |
github-actions
bot
added
the
area/packaging
ilyam8
reviewed
Oct 14, 2020
ilyam8
approved these changes
Oct 14, 2020
Ferroin
approved these changes
Oct 14, 2020
|
@HolgerHees Thanks for the PR, this will be in the release that goes out today, and should show up in the nightlies tomorrow. @joelhans This needs to be added to the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comments for systemd service files are only allowed in the beginning of a new line
https://www.freedesktop.org/software/systemd/man/systemd.syntax.html
otherwise you get error messages like
Summary
Component Name
Test Plan
Additional Information