Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41963: document that ConfigParser strips off comments #26197

Merged
merged 5 commits into from May 18, 2021
Merged

bpo-41963: document that ConfigParser strips off comments #26197

merged 5 commits into from May 18, 2021
+12 −1

Conversation

@jugmac00
Copy link
Contributor

@jugmac00 jugmac00 commented May 17, 2021 •
edited by bedevere-bot

... when reading a configuration file.

https://bugs.python.org/issue41963
@jugmac00
bpo-41963: document that ConfigParser strips off comments
Loading status checks…
b6cac6c
blurb-it bot and others added 2 commits May 17, 2021
@blurb-it
📜🤖 Added by blurb_it.
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
9eaa3c5
@jugmac00
fix typo
Loading status checks…
5c72aa8
@lgfunderburk
Copy link
Contributor

@lgfunderburk lgfunderburk commented May 17, 2021

Reviewing
@lgfunderburk
lgfunderburk suggested changes May 17, 2021
View changes
Copy link
Contributor

@lgfunderburk lgfunderburk left a comment •
edited

Slight wording change on configparser.py

Please note that comments get stripped off on reading

change to

Please note that comments get stripped off when reading

Also, to be consistent, is this about reading configuration files?
@lgfunderburk
lgfunderburk suggested changes May 17, 2021
View changes
Copy link
Contributor

@lgfunderburk lgfunderburk left a comment

Testing review functionality. Sorry for duplicates.
@lgfunderburk
lgfunderburk suggested changes May 17, 2021
View changes
Copy link
Contributor

@lgfunderburk lgfunderburk left a comment

Slight grammar change and consistency on what is being read.
Lib/configparser.py Outdated Show resolved Hide resolved
@jugmac00 @lgfunderburk
Update Lib/configparser.py
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
6c5dfb6 
Co-authored-by: Laura Gutierrez Funderburk <58710704+lgfunderburk@users.noreply.github.com>
@lgfunderburk
lgfunderburk approved these changes May 17, 2021
View changes
Copy link
Contributor

@lgfunderburk lgfunderburk left a comment

Approving changes.
@jugmac00
trigger CI - Azure seems flaky
Loading status checks…
05dec08
@ambv ambv merged commit 02ee819 into python:main May 18, 2021
12 checks passed
12 checks passed
@github-actions
Docs
Details
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
Azure Pipelines PR #20210517.43 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 41963 found
Details
@bedevere-bot
bedevere/news News entry found in Misc/NEWS.d
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 18, 2021

Thanks @jugmac00 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 18, 2021

Sorry @jugmac00 and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 02ee8191263848f8c8999f72286148946b83e5c9 3.10
miss-islington added a commit to miss-islington/cpython that referenced this pull request May 18, 2021
@jugmac00 @miss-islington
bpo-41963: document that ConfigParser strips off comments (pythonGH-2…
9157f44 
…6197)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Laura Gutierrez Funderburk <58710704+lgfunderburk@users.noreply.github.com>
(cherry picked from commit 02ee819)

Co-authored-by: Jürgen Gmach <juergen.gmach@googlemail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 18, 2021

GH-26213 is a backport of this pull request to the 3.9 branch.
@jugmac00 jugmac00 deleted the jugmac00:bpo-41963 branch May 18, 2021
ambv added a commit to ambv/cpython that referenced this pull request May 18, 2021
@jugmac00 @ambv
[3.10] bpo-41963: document that ConfigParser strips off comments (pyt…
Verified
This commit was signed with the committer’s verified signature.
ambv Łukasz Langa
GPG key ID: B26995E310250568 Learn about vigilant mode.
0ef1f77 
…honGH-26197)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Laura Gutierrez Funderburk <58710704+lgfunderburk@users.noreply.github.com>
(cherry picked from commit 02ee819)

Co-authored-by: Jürgen Gmach <juergen.gmach@googlemail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 18, 2021

GH-26214 is a backport of this pull request to the 3.10 branch.
ambv pushed a commit that referenced this pull request May 18, 2021
@miss-islington
bpo-41963: document that ConfigParser strips off comments (GH-26197) (G…
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
c17ba23 
…H-26213)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Laura Gutierrez Funderburk <58710704+lgfunderburk@users.noreply.github.com>
Co-authored-by: Jürgen Gmach <juergen.gmach@googlemail.com>

(cherry picked from commit 02ee819)
ambv added a commit that referenced this pull request May 18, 2021
@ambv
[3.10] bpo-41963: document that ConfigParser strips off comments (GH-…
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
4d17c93 
…26197) (GH-26214)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Laura Gutierrez Funderburk <58710704+lgfunderburk@users.noreply.github.com>
Co-authored-by: Jürgen Gmach <juergen.gmach@googlemail.com>

(cherry picked from commit 02ee819)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgfunderburk lgfunderburk

Assignees

@ambv ambv

Labels
CLA signed
Projects
None yet
Milestone
No milestone
6 participants
@jugmac00 @lgfunderburk @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni