build: update the comment of workspace for bazel version #22712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum bazel version to use with this repo is v4.0.0.
google-cla
bot
added
the
cla: yes
devversion
added
merge ready
crisbeto
reviewed
May 18, 2021
WORKSPACE
Outdated
| @@ -42,7 +42,7 @@ bazel_skylib_workspace() | |||
|
|
|||
| load("@build_bazel_rules_nodejs//:index.bzl", "check_bazel_version", "node_repositories", "yarn_install") | |||
|
|
|||
| # The minimum bazel version to use with this repo is v3.1.0. | |||
| # The minimum bazel version to use with this repo is v4.0.0. | |||
There was a problem hiding this comment.
IMO we can just remove this comment, the code is pretty self-explanatory.
…is repo is v3.1.0.` remove the `# The minimum bazel version to use with this repo is v3.1.0.`, the code is pretty self-explanatory related angular#21722
|
@crisbeto please review |
andrewseguin
pushed a commit
that referenced
this issue
May 19, 2021
* build: update the comment of workspace for bazel version The minimum bazel version to use with this repo is v4.0.0. * build: remove the comment `# The minimum bazel version to use with this repo is v3.1.0.` remove the `# The minimum bazel version to use with this repo is v3.1.0.`, the code is pretty self-explanatory related #21722 (cherry picked from commit ddabd17)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The minimum bazel version to use with this repo is v4.0.0.