Skip to content

docs: use icon button in input clear example #22732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2021
Merged

docs: use icon button in input clear example #22732

merged 1 commit into from
May 24, 2021

Conversation

bampakoa
Copy link
Contributor

Remove the extraneous mat-button directive.

@bampakoa
docs: use icon button in input clear example
8c74848 
Remove the extraneous `mat-button` directive.
@bampakoa bampakoa requested a review from andrewseguin as a code owner May 19, 2021 21:42
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 19, 2021
@andrewseguin andrewseguin added merge safe P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 20, 2021
crisbeto
crisbeto approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 20, 2021
@wagnermaciel wagnermaciel merged commit 04668e0 into angular:master May 24, 2021
wagnermaciel pushed a commit that referenced this pull request May 24, 2021
@bampakoa @wagnermaciel
docs: use icon button in input clear example (#22732)
c8abcd9 
Remove the extraneous `mat-button` directive.

(cherry picked from commit 04668e0)
@bampakoa bampakoa deleted the input-example branch May 24, 2021 17:14
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bampakoa @crisbeto @andrewseguin @wagnermaciel