feat(google-maps): add heatmap support #21489
Conversation
crisbeto
requested review from
devversion and
angular/dev-infra-components
as
code owners
|
LGTM, though @mbehrlich should also take a look |
| } | ||
|
|
||
| if (changes['data'] && _data !== undefined) { | ||
| // TODO(crisbeto): the API allows for `MVCArray<LatLng|WeightedLocation>` or |
crisbeto
Jan 5, 2021
Author
Member
Yeah, I was planning on sending out out, but I haven't gotten around to it yet.
| </head> | ||
| ``` | ||
|
|
||
| **Note:** |
mbehrlich
Jan 5, 2021
Collaborator
There are several classes that we may want to implement in the future that also require adding separate libraries. Should we make this note more general, to apply to several components, while giving more specific instructions about which library to use in the component-specific readme?
crisbeto
Jan 6, 2021
Author
Member
I think it may be too vague if we're doing it now since there aren't any other components that use this approach. It might be better to do it once we have other components.
crisbeto
force-pushed the
crisbeto:google-heatmap
branch
2 times, most recently
from
87d2c81
to
c17ec2b
|
LGTM |
crisbeto
force-pushed the
crisbeto:google-heatmap
branch
2 times, most recently
from
a3a1266
to
cc428ad
|
@crisbeto needs rebase |
Adds support for rendering heatmaps on the `google-map` component using the `map-heatmap-layer` directive. The directive is mostly a direct wrapper around the `google.maps.visualization.HeatmapLayer` class, except for the fact that it also accepts a `LatLngLiteral`, whereas the Google Maps class only accepts `LatLng` objects. I decided to add some logic to convert them automatically, because creating `LatLng` requires the Maps API to have been loaded which can lead to race conditions if it's being loaded lazily.
|
Rebased @annieyw. |
annieyw
merged commit 09581ee
into
angular:master
Adds support for rendering heatmaps on the `google-map` component using the `map-heatmap-layer` directive. The directive is mostly a direct wrapper around the `google.maps.visualization.HeatmapLayer` class, except for the fact that it also accepts a `LatLngLiteral`, whereas the Google Maps class only accepts `LatLng` objects. I decided to add some logic to convert them automatically, because creating `LatLng` requires the Maps API to have been loaded which can lead to race conditions if it's being loaded lazily.
Adds support for rendering heatmaps on the `google-map` component using the `map-heatmap-layer` directive. The directive is mostly a direct wrapper around the `google.maps.visualization.HeatmapLayer` class, except for the fact that it also accepts a `LatLngLiteral`, whereas the Google Maps class only accepts `LatLng` objects. I decided to add some logic to convert them automatically, because creating `LatLng` requires the Maps API to have been loaded which can lead to race conditions if it's being loaded lazily.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds support for rendering heatmaps on the
google-mapcomponent using themap-heatmap-layerdirective. The directive is mostly a direct wrapper around thegoogle.maps.visualization.HeatmapLayerclass, except for the fact that it also accepts aLatLngLiteral, whereas the Google Maps class only acceptsLatLngobjects. I decided to add some logic to convert them automatically, because creatingLatLngrequires the Maps API to have been loaded which can lead to race conditions if it's being loaded lazily.