fix(cdk/text-field): autosize text areas using the placeholder #22197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
jelbourn
reviewed
Mar 11, 2021
|
Had to also adjust the input tests |
Fixes a bug with CdkTextareaAutosize where the textarea would not be autosized when using long placeholders Fixes #22042 Cache the height with the placeholder do calculation better fix comment Stop caching the placeholder because I can't make the caching approach work with view-engine go back to the caching approach Account for the input tests fix lint error
jelbourn
added
target: major
jelbourn
added
the
merge ready
|
Sadly this break g3 because the value is changed on the textarea. I think I will have to abandon this completely as I will be unavailable to look at this for a week and we have other high priority things to deal with right now |
andrewseguin
added a commit
to andrewseguin/components
that referenced
this issue
Mar 19, 2021
angular#22197)" This reverts commit 476a90b.
mmalerba
added a commit
to mmalerba/components
that referenced
this issue
Mar 22, 2021
Roll-forward w/ fix for angular#22197 This reverts commit 4316787.
mmalerba
added a commit
to mmalerba/components
that referenced
this issue
Mar 31, 2021
Roll-forward w/ fix for angular#22197 This reverts commit 4316787.
annieyw
pushed a commit
that referenced
this issue
Apr 2, 2021
* fix(cdk/text-field): autosize text areas using the placeholder Roll-forward w/ fix for #22197 This reverts commit 4316787. * fixup! fix(cdk/text-field): autosize text areas using the placeholder * fixup! fix(cdk/text-field): autosize text areas using the placeholder * fixup! fix(cdk/text-field): autosize text areas using the placeholder * fixup! fix(cdk/text-field): autosize text areas using the placeholder
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes a bug with CdkTextareaAutosize where the textarea would not be autosized when using long placeholders
Fixes #22042