Skip to content

fix(material-experimental/mdc-typography): add missing @import forward #22519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2021
Merged

fix(material-experimental/mdc-typography): add missing @import forward #22519

merged 1 commit into from
May 3, 2021

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Apr 20, 2021 •
edited
Loading

Caretaker note: there's one internal usage that will need to be updated

@mmalerba mmalerba requested a review from crisbeto April 20, 2021 22:37
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 20, 2021
@mmalerba mmalerba added target: patch This PR is targeted for the next patch release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Apr 20, 2021
crisbeto
crisbeto approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Apr 21, 2021
@crisbeto
Copy link
Member

I think the target should be rc, because we don't have Sass modules on the patch branch.

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Apr 22, 2021
@annieyw annieyw merged commit 5f1f4a1 into angular:master May 3, 2021
annieyw pushed a commit that referenced this pull request May 3, 2021
@mmalerba @annieyw
fix(material-experimental/mdc-typography): add missing @import forward (
efc5952 
#22519)

(cherry picked from commit 5f1f4a1)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmalerba @crisbeto @annieyw