Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added arrow function in below files #4061

Merged
merged 17 commits into from Nov 18, 2018
Merged

Added arrow function in below files #4061

merged 17 commits into from Nov 18, 2018

Conversation

@saravyas
Copy link
Contributor

@saravyas saravyas commented Nov 14, 2018

This PR includes arrow function change.

attempt.js Show resolved Hide resolved
@jdalton
Copy link
Member

@jdalton jdalton commented Nov 14, 2018

Thanks @saravyas!

I'm actually fine with these being function declarations though the removal of .apply() is fine. I know it kind of changes the intent of the PR though.

conformsTo.js Outdated Show resolved Hide resolved
conforms.js Outdated Show resolved Hide resolved
cond.js Outdated Show resolved Hide resolved
compact.js Outdated Show resolved Hide resolved
cloneWith.js Outdated Show resolved Hide resolved
before.js Outdated Show resolved Hide resolved
saravyas added 2 commits Nov 14, 2018
cloneDeepWith.js Outdated Show resolved Hide resolved
cloneDeep.js Outdated Show resolved Hide resolved
clone.js Outdated Show resolved Hide resolved
clamp.js Outdated Show resolved Hide resolved
chunk.js Outdated Show resolved Hide resolved
castArray.js Outdated Show resolved Hide resolved
before.js Outdated Show resolved Hide resolved
attempt.js Show resolved Hide resolved
saravyas added 3 commits Nov 17, 2018
saravyas added 4 commits Nov 17, 2018
@jdalton jdalton merged commit 2d7bfd0 into lodash:master Nov 18, 2018
1 check passed
1 check passed
licence/cla Contributor License Agreement is signed.
Details
@jdalton
Copy link
Member

@jdalton jdalton commented Nov 18, 2018

Thank you for your patience and follow-ups @saravyas!

jdalton added a commit that referenced this pull request Nov 18, 2018
@lock
Copy link

@lock lock bot commented Nov 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.