lodash / lodash

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint files #4416

Merged

jdalton merged 3 commits into lodash:master from phapdinh:lint-files

Aug 17, 2019

Contributor

phapdinh commented Aug 17, 2019

This fixes issue issue #4415


          lint files

cd0f73e

jsf-clabot commented Aug 17, 2019 •

edited

All committers have signed the CLA.


          fix merge conflicts

c01d0cc

phapdinh reviewed

.eslintrc.js Outdated

  
      @@ -83,7 +83,7 @@ module.exports = {
    
              'requireReturnForObjectLiteral': false

            }],

            'arrow-parens': ['error', 'always'],

            // 'arrow-parens': ['error', 'always'],

phapdinh Aug 17, 2019
Author Contributor

I commented out this rule because sometimes arrow functions if they have only one parameter don't need parens

jdalton Aug 17, 2019
Member

It's fine to enable. I want to be consistent and always use parens.

phapdinh Aug 17, 2019 •

edited

Author Contributor

@jdalton I have added back this rule and now npm run style passes

jdalton mentioned this pull request

Lint files #4415

Closed


          added back arrow-paren and removed duplicate

47e804d

jdalton added the bug label

Member

jdalton commented Aug 17, 2019

Thank you @phapdinh!

jdalton merged commit 15e1557 into lodash:master

1 check passed

1 check passed

licence/cla Contributor License Agreement is signed.

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.