Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42972: Fully implement GC protocol for ssl heap types (GH-26370) #26370

Merged
merged 1 commit into from May 27, 2021
Merged

bpo-42972: Fully implement GC protocol for ssl heap types (GH-26370) #26370

merged 1 commit into from May 27, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 25, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue42972
@erlend-aasland erlend-aasland requested a review from tiran as a code owner May 25, 2021
erlend-aasland
erlend-aasland reviewed May 25, 2021
View changes
Modules/_ssl.c Show resolved Hide resolved
@tiran tiran self-assigned this May 25, 2021
tiran
tiran approved these changes May 26, 2021
View changes
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 26, 2021

🤖 New build scheduled with the buildbot fleet by @tiran for commit a798fac 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@tiran tiran changed the title bpo-42972: Fully implement GC protocol for ssl heap types bpo-42972: Fully implement GC protocol for ssl heap types (GH-26370) May 27, 2021
@tiran tiran merged commit dcb8786 into python:main May 27, 2021
53 of 75 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 27, 2021

Thanks @erlend-aasland for the PR, and @tiran for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue May 27, 2021
@erlend-aasland @miss-islington
bpo-42972: Fully implement GC protocol for ssl heap types (pythonGH-2…
033e011 
…6370)

(cherry picked from commit dcb8786)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 27, 2021

GH-26399 is a backport of this pull request to the 3.10 branch.

@erlend-aasland erlend-aasland deleted the bpo-47972/ssl branch May 27, 2021
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented May 27, 2021

Thanks, @tiran !

vstinner pushed a commit that referenced this issue May 27, 2021
@erlend-aasland @miss-islington
bpo-42972: Fully implement GC protocol for ssl heap types (GH-26370) (G…
ea47a8a 
…H-26399)

(cherry picked from commit dcb8786)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@pablogsal
Copy link
Member

@pablogsal pablogsal commented May 28, 2021

This PR introduced a regression: it added a GC type without fully implementing the GC protocol. See:

https://bugs.python.org/issue44252

@pablogsal
Copy link
Member

@pablogsal pablogsal commented May 28, 2021 •
edited

Unfortunately, this PR also has introduce reference leaks in the urllib module:

dcb8786a9848516e823e090bb36079678913d8d3 is the first bad commit
commit dcb8786a9848516e823e090bb36079678913d8d3
Author: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Date:   Thu May 27 09:50:09 2021 +0200

    [bpo-42972](https://bugs.python.org/issue42972): Fully implement GC protocol for ssl heap types (GH-26370)

 Modules/_ssl.c | 73 ++++++++++++++++++++++++++++++++++++----------------------
 1 file changed, 45 insertions(+), 28 deletions(-)

example failure:

https://buildbot.python.org/all/#/builders/320/builds/41

@pablogsal
Copy link
Member

@pablogsal pablogsal commented May 29, 2021

Fixed by https://bugs.python.org/issue44252

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@erlend-aasland @JuniorJPDJ
bpo-42972: Fully implement GC protocol for ssl heap types (pythonGH-2…
a01c777 
…6370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran

Assignees

@tiran tiran

Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
6 participants
@erlend-aasland @bedevere-bot @miss-islington @pablogsal @tiran @the-knights-who-say-ni