Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.10] bpo-42972: Fully implement GC protocol for re types (GH-26368) #26414

Merged
merged 1 commit into from May 28, 2021
Merged

[3.10] bpo-42972: Fully implement GC protocol for re types (GH-26368) #26414

merged 1 commit into from May 28, 2021

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 27, 2021 •
edited by bedevere-bot

(cherry picked from commit fba42d1)

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no

https://bugs.python.org/issue42972
@erlend-aasland @miss-islington
bpo-42972: Fully implement GC protocol for re types (pythonGH-26368)
4507ea9 
(cherry picked from commit fba42d1)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 27, 2021

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request May 27, 2021
Merged
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 27, 2021

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .

vstinner
vstinner approved these changes May 27, 2021
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM, good bot.

@vstinner
Copy link
Member

@vstinner vstinner commented May 27, 2021

On a single CI run, https://bugs.python.org/issue44252 occurred 3 times on 4 Windows jobs.

Tests / Windows (x86) (pull_request) Failing after 13m — Windows (x86)

=> 1 test failed: test_asyncio

Tests / Windows (x64) (pull_request) Failing after 13m — Windows (x64)

0:00:32 load avg: 6.46 [ 52/427/1] test_httplib crashed (Exit code 3221225477)
(...)
test_host_port (test.test_httplib.HTTPSTest) ... ok
Windows fatal exception: access violation

Azure Pipelines PR — #20210527.52 failed

64-bit:

test_host_port (test.test_httplib.HTTPSTest) ... ok
Windows fatal exception: access violation

32 bit:

test_host_port (test.test_httplib.HTTPSTest) ... ok
Windows fatal exception: access violation

@vstinner
Copy link
Member

@vstinner vstinner commented May 27, 2021

I re-run GHA jobs.

@vstinner vstinner merged commit da9e0cb into python:3.10 May 28, 2021
11 of 13 checks passed
@miss-islington miss-islington deleted the backport-fba42d1-3.10 branch May 28, 2021
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
5 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot @erlend-aasland