Skip to content

[3.10] Fix dataclass comment typo _eq__ -> __eq__ (GH-26433) #26436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2021
Merged

[3.10] Fix dataclass comment typo _eq__ -> __eq__ (GH-26433) #26436

merged 1 commit into from
May 29, 2021

Conversation

miss-islington
Copy link
Contributor

(cherry picked from commit 7e6f237)

Co-authored-by: Sean Grady vedicmonk@gmail.com

@SeanGrady @miss-islington
Fix dataclass comment typo _eq__ -> __eq__ (pythonGH-26433)
946f98b 
(cherry picked from commit 7e6f237)

Co-authored-by: Sean Grady <vedicmonk@gmail.com>
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@SeanGrady

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot mentioned this pull request May 28, 2021
Merged
@miss-islington
Copy link
Contributor Author

@SeanGrady and @ericvsmith: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@SeanGrady and @ericvsmith: Status check is done, and it's a failure ❌ .

@ericvsmith ericvsmith merged commit 1757ddd into python:3.10 May 29, 2021
@miss-islington miss-islington deleted the backport-7e6f237-3.10 branch May 29, 2021 01:07
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @the-knights-who-say-ni @ericvsmith @bedevere-bot @SeanGrady