Skip to content

fix(dev-infra): add vim .swp files to gitignore #40094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Dec 11, 2020

The vim editor produces temporarily files that can end in both .swo and
.swp. This commits add .swp to the .gitignore so we don't accidentally
commit temporary files.

@zarend zarend added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 11, 2020
@zarend zarend requested a review from atscott December 11, 2020 20:33
@google-cla google-cla bot added the cla: yes label Dec 11, 2020
@zarend zarend requested review from alxhub and removed request for atscott December 11, 2020 20:33
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but defer to @josephperrott in case there's something I'm missing here. It's a little surprising that we don't already have this.

@ayazhafiz
Copy link
Contributor

fun fact: the variety of potential extensions can be endless, if swp is already taken for a file then swo is tried, then swn, etc. http://vimdoc.sourceforge.net/htmldoc/recover.html#swap-file

@crisbeto
Copy link
Member

FYI one .swp file already made it into the repo. Maybe we should take the chance to delete it? https://github.com/angular/angular/blob/master/packages/language-service/.build.sh.swp

The vim editor produces temporarily files that can end in both .swo and
.swp. This commits add .swp to the .gitignore so we don't accidentaly
commit temporary files.
@zarend zarend removed the request for review from alxhub December 14, 2020 16:44
@zarend zarend added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 14, 2020
alxhub pushed a commit that referenced this pull request Dec 14, 2020
The vim editor produces temporarily files that can end in both .swo and
.swp. This commits add .swp to the .gitignore so we don't accidentaly
commit temporary files.

PR Close #40094
@alxhub alxhub closed this in 19d43af Dec 14, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants