Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypy] Add/fix type annotations for scheduling algorithms #4074

Merged
merged 4 commits into from Dec 28, 2020
Merged

[mypy] Add/fix type annotations for scheduling algorithms #4074

merged 4 commits into from Dec 28, 2020

Conversation

@shan7030
Copy link
Contributor

@shan7030 shan7030 commented Dec 27, 2020 

$ mypy --strict scheduling/ --ignore-missing-imports
Success: no issues found in 4 source files

Related Issue: #4052

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
shan7030 added 3 commits Dec 27, 2020
@shan7030
Fix mypy errors for scheduling/first_come_first_served
175716b
@shan7030
Fix mypy errors for scheduling/round_robin.py
dd2ac7c
@shan7030
Fix mypy errors for scheduling/shortest_job_first.py
Loading status checks…
42866c5
@shan7030
Fix isort errors
Loading status checks…
9d68bcf
@dhruvmanila
dhruvmanila approved these changes Dec 28, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

LGTM! 🎉
Thank you for doing this! 👍
@dhruvmanila dhruvmanila merged commit 00e279e into TheAlgorithms:master Dec 28, 2020
2 checks passed
2 checks passed
@github-actions
build
Details
@github-actions
pre-commit
Details
stokhos added a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@shan7030 @stokhos
[mypy] Add/fix type annotations for scheduling algorithms (TheAlgorit…
feecb58 
…hms#4074)

* Fix mypy errors for scheduling/first_come_first_served
* Fix mypy errors for scheduling/round_robin.py
* Fix mypy errors for scheduling/shortest_job_first.py
* Fix isort errors
peRFectBeliever added a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@shan7030 @peRFectBeliever
[mypy] Add/fix type annotations for scheduling algorithms (TheAlgorit…
9529d7f 
…hms#4074)

* Fix mypy errors for scheduling/first_come_first_served
* Fix mypy errors for scheduling/round_robin.py
* Fix mypy errors for scheduling/shortest_job_first.py
* Fix isort errors
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@shan7030
[mypy] Add/fix type annotations for scheduling algorithms (TheAlgorit…
d16a180 
…hms#4074)

* Fix mypy errors for scheduling/first_come_first_served
* Fix mypy errors for scheduling/round_robin.py
* Fix mypy errors for scheduling/shortest_job_first.py
* Fix isort errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@shan7030 @dhruvmanila